Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add opcr project artwork #395

Merged
merged 2 commits into from
Jan 18, 2023
Merged

add opcr project artwork #395

merged 2 commits into from
Jan 18, 2023

Conversation

ogazitt
Copy link
Contributor

@ogazitt ogazitt commented Jan 18, 2023

Signed-off-by: Omri Gazitt ogazitt@gmail.com

Add Open Policy Containers (OPCR) project artwork.

Signed-off-by: Omri Gazitt <ogazitt@gmail.com>
@lukaszgryglicki
Copy link
Member

Hi, can you update the PR so the paths are in standarized form, liek for example: https://github.com/cncf/artwork/tree/master/projects/crossplane

So that would be something like:

  • projects/opcr/icon/color/opcr-icon-color.svg.
  • projects/opcr/icon/color/opcr-icon-color.png.

@caniszczyk
Copy link
Contributor

cc: @ogazitt to do the updates before merging in

@ogazitt
Copy link
Contributor Author

ogazitt commented Jan 18, 2023

Hi, can you update the PR so the paths are in standarized form, liek for example: https://github.com/cncf/artwork/tree/master/projects/crossplane

So that would be something like:

  • projects/opcr/icon/color/opcr-icon-color.svg.
  • projects/opcr/icon/color/opcr-icon-color.png.

Happy to do this, but since we have color logos with light and dark type, we modeled our directory structure on containerssh - https://github.com/cncf/artwork/blob/master/examples/sandbox.md#containerssh-logos

To apply the spirit of your suggestion, I propose the following:

  • projects/opcr/icon/color/opcr-icon-color.svg
  • projects/opcr/icon/color/opcr-icon-color.png
  • projects/opcr/horizontal/color/opcr-horizontal-color.svg
  • projects/opcr/horizontal/color/opcr-horizontal-color.png
  • projects/opcr/horizontal/color/opcr-horizontal-color-dark.svg
  • projects/opcr/horizontal/color/opcr-horizontal-color-dark.png
  • projects/opcr/stacked/color/opcr-stacked-color.svg
  • projects/opcr/stacked/color/opcr-stacked-color.png
  • projects/opcr/stacked/color/opcr-stacked-color-dark.svg
  • projects/opcr/stacked/color/opcr-stacked-color-dark.png

@ogazitt
Copy link
Contributor Author

ogazitt commented Jan 18, 2023

@lukaszgryglicki

Let me know if this works for you:

ogazitt@Omris-MacBook-Pro:~/src/cncf/cncf-artwork/projects/opcr % tree
.
├── horizontal
│   └── color
│       ├── opcr-horizontal-color-dark.png
│       ├── opcr-horizontal-color-dark.svg
│       ├── opcr-horizontal-color.png
│       └── opcr-horizontal-color.svg
├── icon
│   └── color
│       ├── opcr-icon-color.png
│       └── opcr-icon-color.svg
└── stacked
    └── color
        ├── opcr-stacked-color-dark.png
        ├── opcr-stacked-color-dark.svg
        ├── opcr-stacked-color.png
        └── opcr-stacked-color.svg

6 directories, 10 files

@lukaszgryglicki
Copy link
Member

Yep that will work for me. If you don't have some variant, just skip it, but please follow the directory structure I suggested

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm once updated to reflect last two posts

Signed-off-by: Omri Gazitt <ogazitt@gmail.com>
@caniszczyk caniszczyk merged commit 68c730d into cncf:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants