New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old k8s repo groups with SIG-based repo groups #145

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@spiffxp
Contributor

spiffxp commented Oct 12, 2018

This is based off of the kubernetes/community sigs.yaml file.
Auto-generated based on whether the repo shows up in the uris
in the owners fields, and then manually edited to remove some
of the mappings that are shared:

  • kubernetes/kubernetes removed from all SIGS
  • kubernetes/api belongs to sig-arch only
  • kubernetes/client-go belongs to sig-api-machinery only

It's not clear to me whether anyone used the old groups in
this file. It's also not clear to me whether this file should
have delete statements for the old groups if we don't want to
use them.

Replace old k8s repo groups with SIG-based repo groups
This is based off of the kubernetes/community sigs.yaml file.
Auto-generated based on whether the repo shows up in the uris
in the owners fields, and then manually edited to remove some
of the mappings that are shared:

- kubernetes/kubernetes removed from all SIGS
- kubernetes/api belongs to sig-arch only
- kubernetes/client-go belongs to sig-api-machinery only

It's not clear to me whether anyone used the old groups in
this file. It's also not clear to me whether this file should
have delete statements for the old groups if we don't want to
use them.
@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 12, 2018

ref: #141 (comment)

I'm not quite at a point where I'm ready to post, host and run a script, but I tried a trial run and ended up with this, I would like to start the conversation now over whether this is more useful than the repo groups that we have, and what would need to happen for migration

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 15, 2018

Hi @spiffxp - there should not be any delete statements there. It should only contain updates to make specific repos parts of specific repository groups. If I merge this, it will use new repository groups starting now, to change the definition for the past data I would have to regenerate all dashboards data (time-series data only). Let me know if this is a final list and I should regenerate data?

@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 15, 2018

Yes, please regenerate the data. The most common way this list will change in the future is the addition of new repos as they are created. I am curious how long it will take to regenerate though, in the event that repos changes hands due to SIG retirement/merges

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 17, 2018

It takes about 1,5-2 hours. I'll be back on this when I finish some other backlog tasks.

@lukaszgryglicki lukaszgryglicki merged commit 1b1308e into cncf:master Oct 17, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 17, 2018

Merged, data regenerate pending, there was a typo: 9022f04

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 17, 2018

@spiffxp Implemented on the test server. Please take a look (compare with production using old definitions) and confirm that this is what you want. I will update production then.

@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 17, 2018

Thanks I'm looking now and will post back here later today

@nikhita

This comment has been minimized.

Member

nikhita commented Oct 17, 2018

Just wanted to chime in and say that this is a great change. +100 from me. :)

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 17, 2018

Let's give it some time and then let me know if you want me to update prod.
cc @dankohn

@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 18, 2018

I'm going to present this at today's community meeting for any further objections.

@spiffxp spiffxp deleted the spiffxp:update-kubernetes-repo-groups branch Oct 18, 2018

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 18, 2018

Sure, I'll be there. Thanks.

@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 18, 2018

@lukaszgryglicki go ahead and update production

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 19, 2018

OK. Will let you know when done.

@lukaszgryglicki

This comment has been minimized.

Member

lukaszgryglicki commented Oct 19, 2018

Aaron, this is done.

@spiffxp

This comment has been minimized.

Contributor

spiffxp commented Oct 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment