Installs GTM instead of just GA4 #2801
Conversation
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
cjyabraham
requested review from
caniszczyk,
seokho-son,
iamNoah1,
jihoon-seo and
nate-double-u
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
jihoon-seo
added
the
maintainers
| @@ -4,6 +4,12 @@ | |||
| {{ partial "head.html" . }} | |||
| </head> | |||
| <body class="td-{{ .Kind }}"> | |||
| {{ if hugo.IsProduction }} | |||
There was a problem hiding this comment.
From this line, I expected that the lines L9-L10 would not appear in Netlify preview (because it's not prod),
but in the source of the preview, those lines are rendered.
My questions are:
- Is this right? Does Hugo presume Netlify previews as prod?
(Or, it's just Hugo cannot tell Netlify previews and the real prod (https://glossary.cncf.io) apart?) - Would be there no problem if GTM tags are inserted in Netlify preview sites?
There was a problem hiding this comment.
I think it's not correct. Previews should not have analytics and should not be true for IsProduction. It's not a huge concern, however, as it has been how this site has been working from the beginning with Google Analytics and GTM should not be any different.
I suggest we split this problem out as an independent issue and not allow it to hold up merging this PR?
There was a problem hiding this comment.
Here's a new issue for this problem.
To allow us more flexibility we want to install GTM in place of just GA4. We will also be including a HubSpot tracking code using GTM. See cncf/cncf.io#823