New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definitions #304
Definitions #304
Conversation
Thanks for creating this. Content is great! I've added a couple comments just around wording and nits.
@lumjjb ready for ur review.... |
Replied to some of the changes - I think it looks good to me after the minor changes. If @SantiagoTorres can do a review of the deltas and LGTM as well. And let's add this on the agenda of one of the meetings to share this new doc as well!
I like this, although I'm also not fully convinced if the word Other than that, pretty solid work @TheFoxAtWork ! |
I can't approve, but LGTM as well :) |
@ultrasaurus @pragashj @dshaw This looks good to merge.. any additional comments? |
Just waiting for additional comments from co-chairs. can discuss this at next meeting and merge this probably |
This is fabulous. Just one formatting issue before merging -- pls make the sections in the doc be the same order as the index. Looks like that is alphabetical, which seems like a fine approach to me. |
@ultrasaurus made the changes u requested. @SantiagoTorres also added in the link to the definitions on the readme under compromises |
Looks great -- thanks @TheFoxAtWork ! |
Checked with @SantiagoTorres looks good so far