Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graduation: envoy proposal #167

Merged
merged 6 commits into from Nov 28, 2018
Merged

Conversation

mattklein123
Copy link
Contributor

@mattklein123 mattklein123 commented Oct 22, 2018

At the request of @caniszczyk here is Envoy's application to become a graduated project.
Thank you for your consideration!

Signed-off-by: Matt Klein mklein@lyft.com

Signed-off-by: Matt Klein <mklein@lyft.com>
Copy link

@htuch htuch left a comment

Woohoo!

reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
@caniszczyk
Copy link
Contributor

caniszczyk commented Oct 23, 2018

RFC @cncf/toc

dnoe
dnoe approved these changes Oct 23, 2018
Copy link

@dnoe dnoe left a comment

They grow up so fast.

@caniszczyk caniszczyk added this to In progress (due diligence) in TOC Project Backlog Oct 23, 2018
Copy link

@alyssawilk alyssawilk left a comment

Wohoo!

Signed-off-by: Matt Klein <mklein@lyft.com>
reviews/graduation-envoy.md Outdated Show resolved Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
@caniszczyk
Copy link
Contributor

caniszczyk commented Oct 29, 2018

RFC @cncf/toc

proposal LGTM, devstats link is here: https://envoy.devstats.cncf.io


### Document that it is being used successfully in production by at least three independent end users which, in the TOC’s judgement, are of adequate quality and scope.

* Known end users include: AirBnb, Alibaba, Apple, Booking.com, Cookpad, DigitalOcean, eBay, Google, GO-JEK,
Copy link
Contributor

@quinton-hoole quinton-hoole Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify whether all of these companies use Envoy in production. Also, please provide some more detail on the production usage for at least three of the most major uses, e.g. exactly what product/service uses Envoy, indication of scale of usage (both in terms of infrastructure size and number of users), how long it has been used in production etc. This will make it easier to judge the "quality and scope" aspect of the requirement.

Copy link
Contributor Author

@mattklein123 mattklein123 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many/most major users of Envoy are not forthcoming about exactly how they use it and at what scale. Although I know that almost all of the names listed here are in production, some at very large scale, I don't have permission to speak on their behalf. The only one I can speak officially on is Lyft.

@caniszczyk thoughts on best way to proceed here?

Copy link
Contributor

@caniszczyk caniszczyk Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattklein123 as a start, I would ask some adopters to see if they are comfortable publicly stating their usage of Envoy on this PR in more detail

Copy link
Contributor Author

@mattklein123 mattklein123 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking for the Lyft side of things:

  • We run > 20K Envoy instances at once.
  • 100% of edge and StS traffic flows through Envoy.
  • The great majority of external partner traffic flows through Envoy.
  • All MongoDB, Dynamo, and Redis traffic flows through Envoy.
  • Total mesh traffic is 10M+ HTTP/gRPC RPS. Redis query RPS is many multiples of that.

@caniszczyk is going to help with the legwork to see what different companies are willing to say publicly.

Copy link

@taiki45 taiki45 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure Cookpad case is major one though, we can share our usage of Envoy:

  • Our recipe sharing service and some of other services are using Envoy. The Japanese recipe sharing service has more than 55 millions of average monthly users.
  • 700~1200 Envoy instances are running in production.
  • We use Envoy in production since November 2017.
  • Most (more than 3/4) of our internal (service-to-service) traffics flow through Envoy.

Copy link
Contributor

@caniszczyk caniszczyk Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks all, @quinton-hoole-2 would you be comfortable kicking off a graduation vote then?

Copy link
Contributor

@bgrant0607 bgrant0607 Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of kicking off a vote.

Copy link
Contributor

@quinton-hoole quinton-hoole Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caniszczyk Yes, I'm in favor of kicking off the graduation vote. Apologies for my delay replying.

Copy link
Contributor

@caniszczyk caniszczyk Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @quinton-hoole-2, I kicked off the graduation vote: https://lists.cncf.io/g/cncf-toc/message/2633

Copy link
Contributor

@resouer resouer Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quinton-hoole-2 I remembered Huawei also has effort on Envoy, right?

@asantosaEBAY
Copy link

asantosaEBAY commented Nov 7, 2018

At eBay, we are already using Envoy and will increase adoption significantly higher for the next year as well.

@caniszczyk caniszczyk moved this from In progress (due diligence) to TOC Approved (sponsors/voting) in TOC Project Backlog Nov 19, 2018
@caniszczyk caniszczyk merged commit ce522d4 into cncf:master Nov 28, 2018
1 check passed
@caniszczyk caniszczyk moved this from TOC Approved (sponsors/voting) to Done in TOC Project Backlog Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment