Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rook graduation proposal #366

Merged
merged 1 commit into from Oct 7, 2020
Merged

Rook graduation proposal #366

merged 1 commit into from Oct 7, 2020

Conversation

jbw976
Copy link
Contributor

@jbw976 jbw976 commented Feb 26, 2020

This is the formal proposal for the graduation of Rook. All graduation criteria (as well as incubation) and details have been included in this document.

We presented to the storage SIG on Feb 26th. In the next TOC meeting on Mar 3, the SIG provided their recommendation to the TOC that Rook is ready to graduate.

We will now allow our TOC sponsor Saad Ali to call a vote by the TOC.

Please let me know if there's any feedback, clarification, or further additions needed to this proposal.

Fixes #352

@caniszczyk caniszczyk added this to In progress (due diligence/presentation) in Initial Project Triage & Sandbox Projects Backlog via automation Mar 3, 2020
@amye amye moved this from In progress (due diligence/presentation) to SIG Review in Initial Project Triage & Sandbox Projects Backlog Mar 9, 2020
@amye amye added this to Needs TOC Triage & Public Comment Kickoff in Graduating Projects Backlog Mar 13, 2020
@amye amye moved this from Needs TOC Triage & Public Comment Kickoff to In Public Comment Period in Graduating Projects Backlog Mar 13, 2020
@michelleN michelleN moved this from In Public Comment Period to Needs TOC Triage & Public Comment Kickoff in Graduating Projects Backlog Mar 13, 2020
@xiang90
Copy link
Contributor

@xiang90 xiang90 commented Mar 30, 2020

@jbw976

Can you summarize the SIG review suggestions in the doc? Also can you add a link to the DD doc?

See https://github.com/cncf/toc/blob/master/process/graduation-proposal-template.md#incubation-details.

Those two things are also previously required, but not explicitly asked to put into the review/proposal.

@erinaboyd
Copy link
Contributor

@erinaboyd erinaboyd commented Apr 2, 2020

@xiang90 we covered the review during our SIG Storage meeting. The minutes have been gathered here: https://docs.google.com/document/d/1DigEag4UUpf53qYBEr50YIdVJJvhXhxHN5ATj-js-IA/edit

If you would prefer them in a separate doc as an addendum to the original proposal, please let me know.

@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented Apr 3, 2020

@xiang90 I'm happy to incorporate the SIG review notes that @erinaboyd has linked to into the proposal in this PR as well as the SIG recommendation for Rook to graduate.

There actually is no due diligence document for Rook that I know of. When Rook was accepted into Incubation in Sept 2018, there was not a requirement for a DD document nor even a suggestion to do a DD document that I can recall or find anything about. Here is the incubation criteria from Sept 2018 for convenience.

How does the TOC suggest to proceed with this proposal? Thanks!

/cc @saad-ali

@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented Apr 7, 2020

@xiang90 and rest of TOC, I have updated this Rook graduation proposal to match the new template, including details about the due diligence doc status and recommendation/suggestions from the storage SIG.

Please let me know any feedback and I will be happy to incorporate. Thanks!

@jbw976 jbw976 force-pushed the graduation-rook branch 2 times, most recently from 2029f4d to 2263134 Compare Apr 7, 2020
@erinaboyd
Copy link
Contributor

@erinaboyd erinaboyd commented Apr 7, 2020

thanks @jbw976 !

@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented Apr 15, 2020

We have confirmed with @saad-ali that a due diligence doc will be required for this graduation proposal. We will collaborate with the storage SIG to complete the DD doc and update this PR when that has been completed. Thank you for the patience!

@saad-ali
Copy link
Contributor

@saad-ali saad-ali commented May 26, 2020

Rook due diligence doc is here: https://docs.google.com/document/d/1xDd3A3I3GX0hQRCOyKv59RddxjuNgoQQpWzev13mLbk/edit#heading=h.utn0k25x3d0q

I'll follow up with TOC for next steps.

@saad-ali
Copy link
Contributor

@saad-ali saad-ali commented May 28, 2020

As next steps, can someone from SIG Storage please put together a graduation recommendation doc to capture the SIGs recommendation. Similar to this.

Once that is complete, I'll start a thread for public comment period.

@erinaboyd
Copy link
Contributor

@erinaboyd erinaboyd commented May 28, 2020

@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented May 30, 2020

The proposal has been updated with a link to the due diligence doc, thank you for helping us put that together storage SIG!

@erinaboyd it looks like the dd doc will still only allow Red Hat folks in, is it possible to open the link globally for viewers? Thank you!

@travisn
Copy link

@travisn travisn commented Jun 3, 2020

@jbw976, @erinaboyd and I looked into the permissions on the doc and are not seeing how to open it up. Here is a pdf generated from the google doc. Permission can be requested to the original doc if needed as well.
Rook Due Diligence for CNCF Graduation.pdf

@saad-ali Is the pdf sufficient, or do you want to create a copy of the doc under your account?

@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented Jun 4, 2020

@travisn @erinaboyd @saad-ali I've gone ahead and copied the DD doc to a new location that is globally accessible to anyone with the link. The proposal in this PR has been updated with the new link.

Publicly open DD doc: https://docs.google.com/document/d/1acp9gJ1D_qflHKJBg4gB-nZwZQs87_Dh9uiH4pITc_U/edit?usp=sharing

@saad-ali
Copy link
Contributor

@saad-ali saad-ali commented Jun 16, 2020

If the SIG Storage graduation recommendation doc is final, please add a link here and we can move to the next step: public comment period.

Signed-off-by: Jared Watts <jbw976@gmail.com>
@jbw976
Copy link
Contributor Author

@jbw976 jbw976 commented Jun 22, 2020

@saad-ali @erinaboyd I have added the link to that SIG recommendation doc into the PR content as well.

If the SIG has declared the recommendation doc as final (it's quite short, but that may be OK since there were no major concerns), then shall we move on to the public commend period @saad-ali?

@saad-ali
Copy link
Contributor

@saad-ali saad-ali commented Jun 22, 2020

I left some comments on the SIG recommendation doc. But those can be addressed in parallel.

Opened comment period: https://lists.cncf.io/g/cncf-toc/message/4846

@amye amye moved this from Needs TOC Triage & Public Comment Kickoff to In Public Comment Period in Graduating Projects Backlog Jul 6, 2020
@amye amye moved this from In Public Comment Period to In TOC Voting in Graduating Projects Backlog Jul 9, 2020
@erinaboyd
Copy link
Contributor

@erinaboyd erinaboyd commented Jul 20, 2020

@amye where are we in the process?

@amye
Copy link
Contributor

@amye amye commented Jul 20, 2020

The vote is open as of July 6th.

@caniszczyk
Copy link
Contributor

@caniszczyk caniszczyk commented Oct 7, 2020

Rook has been approved for graduation

7/10
Xiang Li: https://lists.cncf.io/g/cncf-toc/message/4937
Matt Klein: https://lists.cncf.io/g/cncf-toc/message/5000
Saad Ali: https://lists.cncf.io/g/cncf-toc/message/5159
Liz Rice: https://lists.cncf.io/g/cncf-toc/message/5174
Alena Prokharchyk: https://lists.cncf.io/g/cncf-toc/message/5223
Katie Gamanji: https://lists.cncf.io/g/cncf-toc/message/5243
Sheng Liang: https://lists.cncf.io/g/cncf-toc/message/5358

@caniszczyk caniszczyk merged commit 9abaa59 into cncf:master Oct 7, 2020
Graduating Projects Backlog automation moved this from In TOC Voting to Done Oct 7, 2020
@monadic
Copy link
Contributor

@monadic monadic commented Oct 7, 2020

@erinaboyd
Copy link
Contributor

@erinaboyd erinaboyd commented Oct 7, 2020

Congrats Rook Community!

@amye amye removed this from Done in Graduating Projects Backlog Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants