-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rook graduation proposal #366
Conversation
Can you summarize the SIG review suggestions in the doc? Also can you add a link to the DD doc? See https://github.com/cncf/toc/blob/master/process/graduation-proposal-template.md#incubation-details. Those two things are also previously required, but not explicitly asked to put into the review/proposal. |
@xiang90 we covered the review during our SIG Storage meeting. The minutes have been gathered here: https://docs.google.com/document/d/1DigEag4UUpf53qYBEr50YIdVJJvhXhxHN5ATj-js-IA/edit If you would prefer them in a separate doc as an addendum to the original proposal, please let me know. |
@xiang90 I'm happy to incorporate the SIG review notes that @erinaboyd has linked to into the proposal in this PR as well as the SIG recommendation for Rook to graduate. There actually is no due diligence document for Rook that I know of. When Rook was accepted into Incubation in Sept 2018, there was not a requirement for a DD document nor even a suggestion to do a DD document that I can recall or find anything about. Here is the incubation criteria from Sept 2018 for convenience. How does the TOC suggest to proceed with this proposal? Thanks! /cc @saad-ali |
@xiang90 and rest of TOC, I have updated this Rook graduation proposal to match the new template, including details about the due diligence doc status and recommendation/suggestions from the storage SIG. Please let me know any feedback and I will be happy to incorporate. Thanks! |
2029f4d
to
2263134
Compare
thanks @jbw976 ! |
We have confirmed with @saad-ali that a due diligence doc will be required for this graduation proposal. We will collaborate with the storage SIG to complete the DD doc and update this PR when that has been completed. Thank you for the patience! |
Rook due diligence doc is here: https://docs.google.com/document/d/1xDd3A3I3GX0hQRCOyKv59RddxjuNgoQQpWzev13mLbk/edit#heading=h.utn0k25x3d0q I'll follow up with TOC for next steps. |
As next steps, can someone from SIG Storage please put together a graduation recommendation doc to capture the SIGs recommendation. Similar to this. Once that is complete, I'll start a thread for public comment period. |
@saad Ali <saadali@google.com> Both @alex Chircop
<alex.chircop@storageos.com> and I will put this together.
Thanks,
Erin
…On Thu, May 28, 2020 at 3:41 PM Saad Ali ***@***.***> wrote:
As next steps, can someone from SIG Storage please put together a
graduation recommendation doc to capture the SIGs recommendation. Similar
to this
<https://docs.google.com/document/d/1IxakOhnAPjN3RFn1jYLvDCAaC_-mj3n-1StJ1CKGdkM/edit#heading=h.tsam72vdrtby>
.
Once that is complete, I'll start a thread for public comment period.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#366 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKMZZWJ4DSN2J42UZDXIO7DRT3LAFANCNFSM4K3544GQ>
.
--
Erin A. Boyd
Senior Principal Software Engineer, OCTO
Red Hat <https://www.redhat.com>
eboyd@redhat.com
<https://red.ht/sig>
|
The proposal has been updated with a link to the due diligence doc, thank you for helping us put that together storage SIG! @erinaboyd it looks like the dd doc will still only allow Red Hat folks in, is it possible to open the link globally for viewers? Thank you! |
@jbw976, @erinaboyd and I looked into the permissions on the doc and are not seeing how to open it up. Here is a pdf generated from the google doc. Permission can be requested to the original doc if needed as well. @saad-ali Is the pdf sufficient, or do you want to create a copy of the doc under your account? |
@travisn @erinaboyd @saad-ali I've gone ahead and copied the DD doc to a new location that is globally accessible to anyone with the link. The proposal in this PR has been updated with the new link. Publicly open DD doc: https://docs.google.com/document/d/1acp9gJ1D_qflHKJBg4gB-nZwZQs87_Dh9uiH4pITc_U/edit?usp=sharing |
If the SIG Storage graduation recommendation doc is final, please add a link here and we can move to the next step: public comment period. |
Signed-off-by: Jared Watts <jbw976@gmail.com>
@saad-ali @erinaboyd I have added the link to that SIG recommendation doc into the PR content as well. If the SIG has declared the recommendation doc as final (it's quite short, but that may be OK since there were no major concerns), then shall we move on to the public commend period @saad-ali? |
I left some comments on the SIG recommendation doc. But those can be addressed in parallel. Opened comment period: https://lists.cncf.io/g/cncf-toc/message/4846 |
@amye where are we in the process? |
The vote is open as of July 6th. |
Rook has been approved for graduation 7/10 |
Congrats Rook Community! |
This is the formal proposal for the graduation of Rook. All graduation criteria (as well as incubation) and details have been included in this document.
We presented to the storage SIG on Feb 26th. In the next TOC meeting on Mar 3, the SIG provided their recommendation to the TOC that Rook is ready to graduate.
We will now allow our TOC sponsor Saad Ali to call a vote by the TOC.
Please let me know if there's any feedback, clarification, or further additions needed to this proposal.
Fixes #352