go: generate and save go protobufs #8
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
@kyessenov I'm hesitant about forming dependencies on Envoy specific projects from UDPA. Is there no way to add some Go stubs or something in this repository? |
|
We can add them here, right next to protos. Is this something you want to commit to? It's hard to change paths once we publish the go generated code (the package prefix is very important in golang). |
|
@kyessenov I think we do need them here ideally (for the UDPA ones). Would you be able to do the plumbing? We also need to setup CI, @lizan do you know the best path for AZP first CI? |
|
We also need to add go module versioning I believe and go manifests (go.mod file). |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
|
Added a script to store generated files. Checked manually with: We probably need a check that the repo is clean after re-generating the files. |
kyessenov
changed the title
bazel/generate_go_protobuf.py
Outdated
| os.chmod(output_file, 0o644) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Who runs this? Should there be a README.md?
There was a problem hiding this comment.
Added bare-bones developer README file.
It should be run by whoever wants to change the API.
It should really be a makefile, but I don't want to get into the debate of makefiles vs bazel.
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
| @@ -0,0 +1,9 @@ | |||
| module github.com/cncf/udpa/go | |||
There was a problem hiding this comment.
NB: go module declaration cannot be placed at the root since go does not like C++ files in test/
Pointing to a repository without go code is not valid go code outside of bazel environment:
The proposal is to use this repo to host the golang generated UDPA protos.
Signed-off-by: Kuat Yessenov kuat@google.com