Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noattachment is true #325

Closed
fengmk2 opened this issue Apr 16, 2014 · 3 comments
Closed

noattachment is true #325

fengmk2 opened this issue Apr 16, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 16, 2014

@fengmk2 fengmk2 added bug labels Apr 16, 2014
@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Apr 16, 2014

sync again work now http://cnpmjs.org/sync/hummus#logid=3635

sync job need to check dist.size

@fengmk2 fengmk2 added this to the v0.4 milestone Apr 16, 2014
@fengmk2 fengmk2 self-assigned this Apr 16, 2014
@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Apr 16, 2014

working on this

@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Apr 16, 2014

try {
    // get tarball
    var r = yield *urllib.request(downurl, options);
    var statusCode = r.status || -1;
    if (statusCode === 404) {
      shasum = sourcePackage.dist.shasum;
      return yield *afterUpload({
        url: downurl
      });
    }
fengmk2 added a commit that referenced this issue Apr 16, 2014
@fengmk2 fengmk2 closed this in a04f5d6 Apr 16, 2014
dead-horse added a commit that referenced this issue Apr 16, 2014
if download tarball 404, throw err better than ignore it. fixed #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.