New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable maxrequests middleware #1003

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
4 participants
@fengmk2
Member

fengmk2 commented Jul 26, 2016

No description provided.

@fengmk2 fengmk2 added the feat label Jul 26, 2016

@fengmk2 fengmk2 added this to the 2.x milestone Jul 26, 2016

@mention-bot

This comment has been minimized.

mention-bot commented Jul 26, 2016

@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dead-horse, @JacksonTian and @greenkeeperio-bot to be potential reviewers

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Jul 26, 2016

@dead-horse koa-middlewares 不知道如何升级是好。。。

@codecov-io

This comment has been minimized.

codecov-io commented Jul 26, 2016

Current coverage is 88.44% (diff: 85.71%)

Merging #1003 into master will decrease coverage by 0.01%

@@             master      #1003   diff @@
==========================================
  Files            85         85          
  Lines          3310       3314     +4   
  Methods         340        340          
  Messages          0          0          
  Branches        618        618          
==========================================
+ Hits           2928       2931     +3   
- Misses          382        383     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update b0f0bc0...54b47ce

@fengmk2 fengmk2 merged commit ea3bece into master Jul 26, 2016

2 of 5 checks passed

Node Security 1 vulnerability found
Details
codecov/project 88.44% (-0.02%) compared to b0f0bc0
Details
security/snyk 1 vulnerable dependency path
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the enable-maxrequests branch Jul 26, 2016

@dead-horse

This comment has been minimized.

Member

dead-horse commented Jul 26, 2016

后面把这些插件单独依赖吧, koa-middlewares 的这种模式不行

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment