New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit sync fails email notice #1006

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
4 participants
@fengmk2
Member

fengmk2 commented Aug 2, 2016

and skip JSONResponseFormatError and 504 server error

fix: limit sync fails email notice
and skip JSONResponseFormatError and 504 server error

@fengmk2 fengmk2 added this to the 2.x milestone Aug 2, 2016

@mention-bot

This comment has been minimized.

mention-bot commented Aug 2, 2016

@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @dead-horse to be a potential reviewer

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Aug 2, 2016

现在每天美国时间高峰期,经常会抛错,而且这些错误都是可以忽略的。

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Aug 2, 2016

image

@codecov-io

This comment has been minimized.

codecov-io commented Aug 2, 2016

Current coverage is 88.62% (diff: 100%)

Merging #1006 into master will increase coverage by 0.15%

@@             master      #1006   diff @@
==========================================
  Files            85         85          
  Lines          3314       3314          
  Methods         340        340          
  Messages          0          0          
  Branches        618        618          
==========================================
+ Hits           2932       2937     +5   
+ Misses          382        377     -5   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update bfbfef8...dcdb27c

@fengmk2 fengmk2 merged commit 7c2f947 into master Aug 2, 2016

3 of 5 checks passed

Node Security 1 vulnerability found
Details
security/snyk 1 vulnerable dependency path
Details
codecov/project 88.62% (+0.15%) compared to bfbfef8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the limit-error-message branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment