New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to use config.registryHost first on setDownloadURL #1044

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
3 participants
@fengmk2
Member

fengmk2 commented Sep 27, 2016

This change is Reviewable

@fengmk2 fengmk2 added the bug label Sep 27, 2016

@fengmk2 fengmk2 added this to the 2.x milestone Sep 27, 2016

@@ -37,7 +37,7 @@ exports.getCDNKey = function (name, filename) {
exports.setDownloadURL = function (pkg, ctx, host) {
if (pkg.dist) {
host = host || ctx.host;
host = host || config.registryHost || ctx.host;

This comment has been minimized.

@fengmk2

fengmk2 Sep 27, 2016

Member

ctx.host 不太好信任,很多 nginx 都是配置错误的。

@fengmk2

fengmk2 Sep 27, 2016

Member

ctx.host 不太好信任,很多 nginx 都是配置错误的。

This comment has been minimized.

@dead-horse
@dead-horse
@dead-horse

This comment has been minimized.

Show comment
Hide comment
@dead-horse
Member

dead-horse commented Sep 27, 2016

+1

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 27, 2016

Current coverage is 88.76% (diff: 100%)

Merging #1044 into master will decrease coverage by 0.03%

@@             master      #1044   diff @@
==========================================
  Files            85         85          
  Lines          3321       3321          
  Methods         340        340          
  Messages          0          0          
  Branches        617        617          
==========================================
- Hits           2949       2948     -1   
- Misses          372        373     +1   
  Partials          0          0          

Powered by Codecov. Last update 74e9bdd...a54a2a5

codecov-io commented Sep 27, 2016

Current coverage is 88.76% (diff: 100%)

Merging #1044 into master will decrease coverage by 0.03%

@@             master      #1044   diff @@
==========================================
  Files            85         85          
  Lines          3321       3321          
  Methods         340        340          
  Messages          0          0          
  Branches        617        617          
==========================================
- Hits           2949       2948     -1   
- Misses          372        373     +1   
  Partials          0          0          

Powered by Codecov. Last update 74e9bdd...a54a2a5

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Sep 27, 2016

Member

我合并发一个版本。

Member

fengmk2 commented Sep 27, 2016

我合并发一个版本。

@fengmk2 fengmk2 merged commit 3262ada into master Sep 27, 2016

5 of 6 checks passed

Node Security 1 vulnerability found
Details
codecov/patch 100% of diff hit (target 88.79%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +11.20% compared to 74e9bdd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new vulnerabilities
Details

@fengmk2 fengmk2 deleted the fix-registry-host branch Sep 27, 2016

@fengmk2

This comment has been minimized.

Show comment
Hide comment
@fengmk2

fengmk2 Sep 27, 2016

Member

2.16.2

Member

fengmk2 commented Sep 27, 2016

2.16.2

@hbrls hbrls referenced this pull request Nov 15, 2016

Closed

tarball url 错误 #1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment