New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add put /:name/:tag, close #332 #333

Merged
merged 2 commits into from Apr 18, 2014

Conversation

Projects
None yet
2 participants
@dead-horse
Member

dead-horse commented Apr 18, 2014

No description provided.

@dead-horse dead-horse added this to the v0.4 milestone Apr 18, 2014

exports.updateTag = function *() {
var version = this.request.body;
var tag = this.params.tag;
var name =this.params.name;

This comment has been minimized.

@fengmk2

fengmk2 Apr 18, 2014

Member

space

var mod = yield Module.get(name, version);
if (!mod) {
this.status = 403;

This comment has been minimized.

@fengmk2

fengmk2 Apr 18, 2014

Member

this should be 404

This comment has been minimized.

@dead-horse

dead-horse Apr 18, 2014

Member

npm return 403..

This comment has been minimized.

@fengmk2

fengmk2 Apr 18, 2014

Member

...... got it

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Apr 18, 2014

LGTM

fengmk2 added a commit that referenced this pull request Apr 18, 2014

Merge pull request #333 from cnpm/issue332-tag
add put /:name/:tag, close #332

@fengmk2 fengmk2 merged commit 6aae538 into master Apr 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the issue332-tag branch Apr 18, 2014

@fengmk2 fengmk2 added the enhancement label Apr 18, 2014

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Apr 18, 2014

厄, 用户权限校验呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment