New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync popular modules, close #468 #472

Merged
merged 2 commits into from Oct 13, 2014

Conversation

Projects
None yet
2 participants
@dead-horse
Member

dead-horse commented Oct 12, 2014

  • add sync popular modules
    • config.syncPopular
    • config.syncPopularInterval
    • topPopular
  • change ms to humanize-ms

dead-horse added some commits Oct 12, 2014

@dead-horse dead-horse added this to the 1.0 milestone Oct 12, 2014

logger.syncInfo(data);
}
if (!config.debug) {
sendMailToAdmin(error, data, new Date());

This comment has been minimized.

@fengmk2

fengmk2 Oct 13, 2014

Member

沒有錯誤還發郵件?

This comment has been minimized.

@dead-horse

dead-horse Oct 13, 2014

Member

可能会有同步失败的,但是没有错误。 sendMail 里面的逻辑会处理

registry: 'http://r.cnpmjs.org', // registry.npmjs.org/-/short is 404 now.
});
return r.data;
};
exports.getPopular = function* (top, timeout) {
var r = yield *request('/-/_view/dependedUpon?group_level=1', {

This comment has been minimized.

@fengmk2

fengmk2 Oct 13, 2014

Member

we need to impl this api too?

This comment has been minimized.

@dead-horse

dead-horse Oct 13, 2014

Member

感觉可以等私有的搞定之后做个私有的,公共的可以直接代理到 NPM ?

This comment has been minimized.

@fengmk2

fengmk2 Oct 13, 2014

Member

嗯,有道理 +1
2014-10-13 上午11:52于 "Yiyu He" notifications@github.com写道:

In proxy/npm.js:

 registry: 'http://r.cnpmjs.org', // registry.npmjs.org/-/short is 404 now.

});
return r.data;
};
+
+exports.getPopular = function* (top, timeout) {

  • var r = yield *request('/-/_view/dependedUpon?group_level=1', {

感觉可以等私有的搞定之后做个私有的,公共的可以直接代理到 NPM ?


Reply to this email directly or view it on GitHub
https://github.com/cnpm/cnpmjs.org/pull/472/files#r18753302.

@fengmk2 fengmk2 added the feat label Oct 13, 2014

fengmk2 added a commit that referenced this pull request Oct 13, 2014

Merge pull request #472 from cnpm/issue468-upon
add sync popular modules, close #468

@fengmk2 fengmk2 merged commit 05c6d7b into master Oct 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the issue468-upon branch Oct 13, 2014

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Oct 13, 2014

@dead-horse 你跟安琪給我的微信發一個數字: 396892 , 在線等...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment