New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't sync constructor package on exists mode #883

Merged
merged 1 commit into from Apr 9, 2016

Conversation

Projects
None yet
5 participants
@fengmk2
Member

fengmk2 commented Apr 9, 2016

closes #857

@fengmk2 fengmk2 added the bug label Apr 9, 2016

@fengmk2 fengmk2 added this to the 2.x milestone Apr 9, 2016

@mention-bot

This comment has been minimized.

mention-bot commented Apr 9, 2016

By analyzing the blame information on this pull request, we identified @dead-horse to be a potential reviewer

@fengmk2 fengmk2 added the in progress label Apr 9, 2016

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Apr 9, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Apr 9, 2016

Current coverage is 88.18%

Merging #883 into master will increase coverage by +0.03% as of 2eb8d88

@@            master    #883   diff @@
======================================
  Files           85      85       
  Stmts         3250    3250       
  Branches       602     602       
  Methods          0       0       
======================================
+ Hit           2865    2866     +1
  Partial         17      17       
+ Missed         368     367     -1

Review entire Coverage Diff as of 2eb8d88


Uncovered Suggestions

  1. +0.28% via .../web/package/show.js#159...167
  2. +0.28% via ...ync_module_worker.js#432...440
  3. +0.22% via services/npm.js#126...132
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@fengmk2 fengmk2 merged commit e0213e1 into master Apr 9, 2016

3 checks passed

codecov/project 88.18% (+0.03%) compared to a74d60c at 88.15%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the fix-missing-sync-constructor-package branch Apr 9, 2016

@fengmk2 fengmk2 removed the in progress label Apr 9, 2016

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Apr 9, 2016

2.9.4

@glen-84

This comment has been minimized.

glen-84 commented Apr 9, 2016

Thank you so much! I will test this early next week.

@glen-84

This comment has been minimized.

glen-84 commented Apr 11, 2016

Verified fixed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment