New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getModuleByRange don't list all packages #990

Merged
merged 1 commit into from Jul 11, 2016

Conversation

Projects
None yet
4 participants
@dead-horse
Member

dead-horse commented Jul 11, 2016

related: #989

@dead-horse dead-horse added the refactor label Jul 11, 2016

@dead-horse dead-horse added this to the 2.x milestone Jul 11, 2016

@mention-bot

This comment has been minimized.

mention-bot commented Jul 11, 2016

@dead-horse, thanks for your PR! By analyzing the annotation information on this pull request, we identified @fengmk2 and @JacksonTian to be potential reviewers

@codecov-io

This comment has been minimized.

codecov-io commented Jul 11, 2016

Current coverage is 88.42%

Merging #990 into master will increase coverage by 0.01%

@@             master       #990   diff @@
==========================================
  Files            85         85          
  Lines          3307       3310     +3   
  Methods         340        340          
  Messages          0          0          
  Branches        617        618     +1   
==========================================
+ Hits           2924       2927     +3   
  Misses          383        383          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 79ac9fb...2c606ef

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Jul 11, 2016

+1

@fengmk2 fengmk2 merged commit 932547a into master Jul 11, 2016

3 of 5 checks passed

security/snyk 1 vulnerable dependency path
Details
Node Security nsp check
Details
codecov/project 88.42% (+0.01%) compared to 79ac9fb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@fengmk2 fengmk2 deleted the fix-get-by-range branch Jul 11, 2016

@fengmk2

This comment has been minimized.

Member

fengmk2 commented Jul 11, 2016

2.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment