password may contains ":" #999

Merged
merged 2 commits into from Aug 4, 2016

Projects

None yet

6 participants

@wenbing
Contributor
wenbing commented Jul 19, 2016

No description provided.

@wenbing wenbing password may contains ":"
4cbeb56
@mention-bot

@wenbing, thanks for your PR! By analyzing the annotation information on this pull request, we identified @fengmk2 and @dead-horse to be potential reviewers

@codecov-io
codecov-io commented Jul 19, 2016 edited

Current coverage is 88.44% (diff: 83.33%)

Merging #999 into master will decrease coverage by 0.01%

@@             master       #999   diff @@
==========================================
  Files            85         85          
  Lines          3310       3315     +5   
  Methods         340        340          
  Messages          0          0          
  Branches        618        618          
==========================================
+ Hits           2928       2932     +4   
- Misses          382        383     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update b0f0bc0...c0f7fab

@alsotang
Member

+1

@dead-horse
Member

补一个密码包含 : 的测试用例吧

@fengmk2
Member
fengmk2 commented Jul 26, 2016

Please add a test case.

@alsotang
Member

我建议还是项目的维护者帮忙写一下测试吧,毕竟这不是一个简单的工具库,这种又有配置又有状态又有数据库外部依赖的项目,跑起来不容易。

2016-07-30 9:09 GMT+08:00 wenbing notifications@github.com:

这个怎么解决啊?

➜ cnpmjs.org git:(master) npm test

cnpmjs.org@0.3.10 test /Users/wenbingzheng/workspace/wenbing/cnpmjs.org
make install && make jshint && make test

microtime@0.5.1 install /Users/wenbingzheng/workspace/wenbing/
cnpmjs.org/node_modules/microtime
node-gyp rebuild

CXX(target) Release/obj.target/microtime/src/microtime.o
In file included from ../src/microtime.cc:11:
../../nan/nan.h:318:13: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::Error, errmsg);
^~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                             ~~~~~~~~~~~~^

../../nan/nan.h:322:5: error: no member named 'ThrowException' in
namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^~
../../nan/nan.h:303:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^
../../nan/nan.h:322:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::Error, errmsg);
^

../../nan/nan.h:303:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg));
^~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                             ~~~~~~~~~~~~^

../../nan/nan.h:327:9: error: no type named 'ThrowException' in namespace
'v8'
v8::ThrowException(error);
^
../../nan/nan.h:334:53: error: no member named 'New' in 'v8::String'; did
you mean 'v8::TypeSwitch::New'?
v8::Localv8::Value err = v8::Exception::Error(v8::String::New(msg));
^

v8::TypeSwitch::New
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/v8.h:4705:28: note:
'v8::TypeSwitch::New' declared here
static Local New(Local type);
^
In file included from ../src/microtime.cc:11:
../../nan/nan.h:334:69: error: calling a private constructor of class
'v8::Localv8::FunctionTemplate'
v8::Localv8::Value err = v8::Exception::Error(v8::String::New(msg));
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/v8.h:326:13: note:
declared private here
V8_INLINE Local(S* that)
^
In file included from ../src/microtime.cc:11:
../../nan/nan.h:336:65: error: too few arguments to function call,
expected 2, have 1
obj->Set(v8::String::New("code"), v8::Int32::New(errorNumber));

/Users/wenbingzheng/.node-gyp/4.4.1/include/node/v8.h:2499:3: note: 'New'
declared here
static Local New(Isolate* isolate, int32_t value);
^
In file included from ../src/microtime.cc:11:
../../nan/nan.h:336:26: error: no member named 'New' in 'v8::String'
obj->Set(v8::String::New("code"), v8::Int32::New(errorNumber));
~~~~~~~~~~^
../../nan/nan.h:348:12: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                                 ~~~~~~~~~~~~^

../../nan/nan.h:352:5: error: no member named 'ThrowException' in
namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:303:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg)); \
~~^
../../nan/nan.h:352:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::TypeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:303:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg)); \
^~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                                 ~~~~~~~~~~~~^

../../nan/nan.h:356:12: error: no member named 'New' in 'v8::String'
return _NAN_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                                 ~~~~~~~~~~~~^

../../nan/nan.h:360:5: error: no member named 'ThrowException' in
namespace 'v8'
_NAN_THROW_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:303:11: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg)); \
~~^
../../nan/nan.h:360:5: error: no member named 'New' in 'v8::String'
_NAN_THROW_ERROR(v8::Exception::RangeError, errmsg);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:303:26: note: expanded from macro '_NAN_THROW_ERROR'
v8::ThrowException(_NAN_ERROR(fun, errmsg)); \
^~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:298:50: note: expanded from macro '_NAN_ERROR'
define _NAN_ERROR(fun, errmsg) fun(v8::String::New(errmsg))

                                 ~~~~~~~~~~~~^

../../nan/nan.h:379:13: error: no member named 'smalloc' in namespace
'node'
, node::smalloc::FreeCallback callback
~~~~~~^
../../nan/nan.h:119:71: note: expanded from macro 'NAN_INLINE'
define NAN_INLINE(declarator) inline *attribute*((always_inline))
declarator

                                                                  ^~~~~~~~~~

../../nan/nan.h:389:12: error: no matching function for call to 'New'
return node::Buffer::New(data, size);
^~~~~~~~~~~~~~~~~
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:28:40:
note: candidate function not viable: no known conversion from 'char

*' to 'v8::Isolate *' for 1st argument NODE_EXTERN
v8::MaybeLocalv8::Object New(v8::Isolate* isolate, size_t length);
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:31:40:
note: candidate function not viable: no known conversion from 'char

*' to 'v8::Isolate *' for 1st argument NODE_EXTERN
v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:43:40:
note: candidate function not viable: requires 3 arguments, but 2 were
provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:36:40:
note: candidate function not viable: requires 5 arguments, but 2 were
provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
In file included from ../src/microtime.cc:11:
../../nan/nan.h:393:12: error: no matching function for call to 'New'
return node::Buffer::New(size);
^~~~~~~~~~~~~~~~~
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:28:40:
note: candidate function not viable: requires 2 arguments, but 1 was
provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate, size_t
length);
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:31:40:
note: candidate function not viable: requires at least 2 arguments, but
1 was provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:43:40:
note: candidate function not viable: requires 3 arguments, but 1 was
provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/node_buffer.h:36:40:
note: candidate function not viable: requires 5 arguments, but 1 was
provided
NODE_EXTERN v8::MaybeLocalv8::Object New(v8::Isolate* isolate,
^
In file included from ../src/microtime.cc:11:
../../nan/nan.h:400:26: error: no member named 'Use' in namespace
'node::Buffer'
return node::Buffer::Use(data, size);
~~~~~~~~~~~~^
../../nan/nan.h:668:49: error: too few arguments to function call, single
argument 'isolate' was not specified
v8::Localv8::Object obj = v8::Object::New();
~~~~~~~~~~~~~ ^
/Users/wenbingzheng/.node-gyp/4.4.1/include/node/v8.h:2933:3: note: 'New'
declared here
static Local New(Isolate* isolate);
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[1]: *** [Release/obj.target/microtime/src/microtime.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit
(/Users/wenbingzheng/workspace/nvm/versions/node/v4.4.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:276:23)
gyp ERR! stack at emitTwo (events.js:87:13)
gyp ERR! stack at ChildProcess.emit (events.js:172:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit
(internal/child_process.js:200:12)
gyp ERR! System Darwin 15.6.0
gyp ERR! command
"/Users/wenbingzheng/workspace/nvm/versions/node/v4.4.1/bin/node"
"/Users/wenbingzheng/workspace/nvm/versions/node/v4.4.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js"
"rebuild"
gyp ERR! cwd /Users/wenbingzheng/workspace/wenbing/
cnpmjs.org/node_modules/microtime
gyp ERR! node -v v4.4.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
npm ERR! Darwin 15.6.0
npm ERR! argv
"/Users/wenbingzheng/workspace/nvm/versions/node/v4.4.1/bin/node"
"/Users/wenbingzheng/workspace/nvm/versions/node/v4.4.1/bin/npm" "install"
"--registry=http://r.cnpmjs.org" "--disturl=http://dist.cnpmjs.org"
npm ERR! node v4.4.1
npm ERR! npm v3.8.5
npm ERR! code ELIFECYCLE

npm ERR! microtime@0.5.1 install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the microtime@0.5.1 install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm
installed.
npm ERR! If you do, this is most likely a problem with the microtime
package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project
with:
npm ERR! npm bugs microtime
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls microtime
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /Users/wenbingzheng/workspace/wenbing/cnpmjs.org/npm-debug.log
make: *** [install] Error 1
npm ERR! Test failed. See above for more details.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/cnpm/cnpmjs.org/pull/999#issuecomment-236329466>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABGB74u2oNg7m8Opk4SmVB7GezrO6CO6ks5qaqQ4gaJpZM4JPkvj>
.

@dead-horse
Member

用 cnpm 安装依赖试试。

我建议还是项目的维护者帮忙写一下测试吧,毕竟这不是一个简单的工具库,这种又有配置又有状态又有数据库外部依赖的项目,跑起来不容易。

并没有很复杂,不需要配置任何数据库就可以跑起来测试,只需要 cnpm install,然后写自己的 test case, 然后 npm test

@dead-horse
Member

你能告诉我这个依赖哪里来的么? microtime? 我在 cnpmjs.org 的整个依赖树里面都没见到这个模块,你不是从 master 拉出来的分支?

@wenbing
Contributor
wenbing commented Aug 1, 2016

貌似 fork 的代码过期了。。。

@wenbing wenbing add test case for password contains ':'
c0f7fab
@fengmk2
Member
fengmk2 commented Aug 4, 2016

+1

@fengmk2 fengmk2 merged commit 1c936d4 into cnpm:master Aug 4, 2016

1 of 4 checks passed

Node Security 1 vulnerability found
Details
codecov/project 88.44% (-0.02%) compared to b0f0bc0
Details
security/snyk 1 vulnerable dependency path
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fengmk2
Member
fengmk2 commented Aug 4, 2016

2.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment