New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RA1 Ch01] Add Exceptions #1933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1927 Added content for Exceptions from RM with modifications
pgoyal01
requested review from
walterkozlowski,
tomkivlin,
iangardner22 and
a team
August 27, 2020 17:18
tomkivlin
reviewed
Aug 27, 2020
tomkivlin
reviewed
Aug 27, 2020
tomkivlin
reviewed
Aug 27, 2020
Updates to 1.4.1 to incorporate @tomkivlin suggestions Corrected a link to Exception Types
[1.4.1 Exceptions](https://github.com/cntt-n/CNTT/blob/pgoyal01-patch-RA1-CH1-4-1/doc/ref_arch/openstack/chapters/chapter01.md#1.4.1) -- make language changes and fix typos
tomkivlin
approved these changes
Aug 28, 2020
As per suggestion from @iangardner22
iangardner22
approved these changes
Aug 28, 2020
walterkozlowski
approved these changes
Aug 29, 2020
@scottsteinbrueck Can you please approve and merge? Thanks |
scottsteinbrueck
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1927
Added content for Exceptions from RM with modifications