New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cEP-13.md: cobot enhancement and porting #77

Merged
merged 1 commit into from May 29, 2017

Conversation

6 participants
@meetmangukiya
Copy link
Member

meetmangukiya commented May 10, 2017

Closes #75

cEP-0009.md Outdated
This cEP describes the details of the process of porting
[cobot](https://gitlab.com/coala/cobot) from hubot(coffeescript framework) to
[errbot](http://errbot.io)(python framework) and about the new features that are
to be added to cobot as a part of the

This comment has been minimized.

@gitmate-bot

gitmate-bot May 10, 2017

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section spacing.

The issue can be fixed by applying the following patch:

--- a/cEP-0009.md
+++ b/cEP-0009.md
@@ -16,7 +16,7 @@
 This cEP describes the details of the process of porting
 [cobot](https://gitlab.com/coala/cobot) from hubot(coffeescript framework) to
 [errbot](http://errbot.io)(python framework) and about the new features that are
-to be added to cobot as a part of the 
+to be added to cobot as a part of the
 [GSoC project](https://summerofcode.withgoogle.com/projects/#4913450777051136).
 
 ## New Features
cEP-0009.md Outdated
### lang2
1. ...
2. ...
3. ...

This comment has been minimized.

@meetmangukiya

meetmangukiya May 10, 2017

Author Member

A link to all the bears

This comment has been minimized.

@Udayan12167

Udayan12167 May 14, 2017

Contributor

Can you describe how the output would look like and a brief overview of how the command will work on the backend. Like errbot will make a request to which api endpoint of webservices and so on

This comment has been minimized.

@meetmangukiya

meetmangukiya May 21, 2017

Author Member

Added the endpoint that will be used and how will be the flow of the plugin

cEP-0009.md Outdated
> cobot run BearName setting1=value setting2=value ...
..BearName2 setting1=value setting2=value ...
```
\#TODO confirm from hemangsk if passing settings will be possible in the

This comment has been minimized.

@hemangsk

hemangsk May 12, 2017

Member

Yes! 👍 By Phase 1

This comment has been minimized.

@meetmangukiya

meetmangukiya May 12, 2017

Author Member

Thanks! I didn't even have to ask :D

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from 0cf2013 to d6f777f May 12, 2017

cEP-0009.md Outdated
This cEP describes the details of the process of porting
[cobot](https://gitlab.com/coala/cobot) from hubot(coffeescript framework) to
[errbot](http://errbot.io)(python framework) and about the new features that are
to be added to cobot as a part of the

This comment has been minimized.

@Udayan12167

Udayan12167 May 14, 2017

Contributor

A sample code of a simple hello world command port from hubot to errbot should be mentioned here.

This comment has been minimized.

@meetmangukiya

meetmangukiya May 21, 2017

Author Member

Added a sample plugin example

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from d6f777f to a769920 May 21, 2017

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from a769920 to 7bd553d May 21, 2017

cEP-0009.md Outdated

### stats(bears, languages, contribution)

Query the webservices at appropriate end point according to the stat requested.

This comment has been minimized.

@Udayan12167

Udayan12167 May 25, 2017

Contributor

Even for this add endpoint.

This comment has been minimized.

@meetmangukiya

meetmangukiya May 25, 2017

Author Member

done 👍

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from 7bd553d to 98ecfaf May 25, 2017

cEP-0009.md Outdated
for both bear and language stats. Language stats will be computed from the
languages key of the given object
2. /contrib
for contribution stats

This comment has been minimized.

@gitmate-bot

gitmate-bot May 25, 2017

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section spacing.

The issue can be fixed by applying the following patch:

--- a/cEP-0009.md
+++ b/cEP-0009.md
@@ -61,7 +61,7 @@
     for both bear and language stats. Language stats will be computed from the
     languages key of the given object
 2. /contrib
-    for contribution stats 
+    for contribution stats
 

cobot contrib stats

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch 2 times, most recently from 77a465a to fc7cf52 May 25, 2017

@jayvdb

This comment has been minimized.

Copy link
Member

jayvdb commented May 26, 2017

Instead of proscribing commands that interact with specific webservices, the webservices should be described using a webservice description language, or use REST, and then the bot generically maps those webservices into commands.

Then as new webservices are added, the bot only needs a restart or similar to load up the new commands.

@jayvdb

This comment has been minimized.

Copy link
Member

jayvdb commented May 26, 2017

The cEP should mention the obvious : We need a Python bot.

And then it should give a high level assessment of the most advanced python bots that exist, evaluating them, and explaining why errbot was selected.

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented May 27, 2017

Instead of proscribing commands that interact with specific webservices, the webservices should be described using a webservice description language, or use REST, and then the bot generically maps those webservices into commands.

👍 I will add this, I think I can fit this in the timeline somewhere

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from fc7cf52 to 66c47e7 May 27, 2017

cEP-0009.md Outdated

coala community has grown substantially over last few months. To make it
easier on maintainers to cope up and still be a welcoming community for new
contributors, cobot is used.

This comment has been minimized.

@gitmate-bot

gitmate-bot May 27, 2017

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section spacing.

The issue can be fixed by applying the following patch:

--- a/cEP-0009.md
+++ b/cEP-0009.md
@@ -23,7 +23,7 @@
 
 coala community has grown substantially over last few months. To make it
 easier on maintainers to cope up and still be a welcoming community for new
-contributors, cobot is used. 
+contributors, cobot is used.
 Currently, cobot is a hubot instance, scripts for which are written
 in Coffeescript.
 

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from 66c47e7 to f6da320 May 27, 2017

cEP-0009.md Outdated

coala community has grown substantially over last few months. To make it
easier on maintainers to cope up and still be a welcoming community for new
contributors, cobot is used.

This comment has been minimized.

@gitmate-bot

gitmate-bot May 27, 2017

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section spacing.

The issue can be fixed by applying the following patch:

--- a/cEP-0009.md
+++ b/cEP-0009.md
@@ -23,7 +23,7 @@
 
 coala community has grown substantially over last few months. To make it
 easier on maintainers to cope up and still be a welcoming community for new
-contributors, cobot is used. 
+contributors, cobot is used.
 Currently, cobot is a hubot instance, scripts for which are written
 in Coffeescript.
 

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from f6da320 to adb901b May 27, 2017

cEP-0009.md Outdated

coala community has grown substantially over last few months. To make it
easier on maintainers to cope up and still be a welcoming community for new
contributors, cobot is used.

This comment has been minimized.

@gitmate-bot

gitmate-bot May 27, 2017

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section spacing.

The issue can be fixed by applying the following patch:

--- a/cEP-0009.md
+++ b/cEP-0009.md
@@ -23,7 +23,7 @@
 
 coala community has grown substantially over last few months. To make it
 easier on maintainers to cope up and still be a welcoming community for new
-contributors, cobot is used. 
+contributors, cobot is used.
 Currently, cobot is a hubot instance, scripts for which are written
 in Coffeescript.
 

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch 2 times, most recently from fdf839e to 9584f8a May 27, 2017

@Udayan12167

This comment has been minimized.

Copy link
Contributor

Udayan12167 commented May 29, 2017

ack 9584f8a

@Udayan12167

This comment has been minimized.

Copy link
Contributor

Udayan12167 commented May 29, 2017

You need to rebase @meetmangukiya

@Udayan12167

This comment has been minimized.

Copy link
Contributor

Udayan12167 commented May 29, 2017

And get a review from @jayvdb

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from 9584f8a to 4ec3826 May 29, 2017

@meetmangukiya meetmangukiya changed the title cEP-0009.md: cobot enhancement and porting cEP-13.md: cobot enhancement and porting May 29, 2017

@meetmangukiya meetmangukiya force-pushed the meetmangukiya:meet/9 branch from 4ec3826 to 9b274bc May 29, 2017

@Udayan12167

This comment has been minimized.

Copy link
Contributor

Udayan12167 commented May 29, 2017

ack 9b274bc

@Udayan12167

This comment has been minimized.

Copy link
Contributor

Udayan12167 commented May 29, 2017

@rultor merge

@rultor

This comment has been minimized.

Copy link

rultor commented May 29, 2017

@rultor merge

@Udayan12167 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 9b274bc into coala:master May 29, 2017

3 checks passed

review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Copy link

rultor commented May 29, 2017

@rultor merge

@Udayan12167 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment