New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement for RubocopBear #1839

Closed
yash-nisar opened this Issue Jun 14, 2017 · 2 comments

Comments

3 participants
@yash-nisar
Member

yash-nisar commented Jun 14, 2017

We should only generate the config_file if rubocop_config is not given as an argument. In this case, the config_file is generated everytime.

See this for reference.

difficulty/low
area/lintbears
size/S

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jun 14, 2017

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes coala#1839
@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Jun 15, 2017

Member

Copying parts of #1841 (review) that are more relevant for further discussion even after that PR is merged.

It looks like you might be solving #1077

More broadly, is this a performance problem affecting all bears that use a config file?
Is it documented that bears should do this when they have a config file?
Is this the only bear which doesnt do it? Is there bugs about fixing the others?

See coala/coala#4072 for my initial attempt at trying to find a way to make config files a native part of the Linter class.

Member

jayvdb commented Jun 15, 2017

Copying parts of #1841 (review) that are more relevant for further discussion even after that PR is merged.

It looks like you might be solving #1077

More broadly, is this a performance problem affecting all bears that use a config file?
Is it documented that bears should do this when they have a config file?
Is this the only bear which doesnt do it? Is there bugs about fixing the others?

See coala/coala#4072 for my initial attempt at trying to find a way to make config files a native part of the Linter class.

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jun 15, 2017

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes coala#1839
@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Jun 15, 2017

Member

some answers at #1841 (comment)

@yash-nisar , which other bears have this problem? Can you create 'low' bugs for them, and use your PR as an example for them to follow.

Member

jayvdb commented Jun 15, 2017

some answers at #1841 (comment)

@yash-nisar , which other bears have this problem? Can you create 'low' bugs for them, and use your PR as an example for them to follow.

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jun 15, 2017

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes coala#1839

@rultor rultor closed this in #1841 Jun 15, 2017

gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes coala#1839

umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes coala#1839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment