Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitCommitBear: use git-url-parse #2330

Closed
jayvdb opened this issue Mar 10, 2018 · 2 comments

Comments

@jayvdb
Copy link
Member

commented Mar 10, 2018

Fetching and parsing of remotes can be done in an external library, and we are using one for the coala/community project, e.g. https://github.com/coala/community/blob/master/requirements.txt

However, first, these upstream issues should be solved.

https://github.com/retr0h/git-url-parse/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Alternatively, and probably better, that functionality might be added to IGitt

@gitmate-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2018

GitMate.io thinks possibly related issues are #211 (GitCommitBear should search for the .git directory recursively), #1331 (GitCommitBear/body_regex: Use re.fullmatch instead of re.search?), #1974 (GitCommitBear: maxent_treebank_pos_tagger is not used), #989 (GitCommitBear false positive), and #1112 (GitCommitBear: Require the commit message body contains a URL pattern).

sks444 added a commit to sks444/coala-bears that referenced this issue Mar 19, 2018

sks444 added a commit to sks444/coala-bears that referenced this issue Mar 19, 2018

@virresh

This comment has been minimized.

Copy link
Member

commented Apr 7, 2018

We might also want to have https://github.com/nephila/giturlparse
Whichever is released earlier

sks444 added a commit to sks444/coala-bears that referenced this issue Apr 28, 2018

GitCommitBear.py: use giturlparse
This uses an external library for
fetching and parsing of remotes.

Closes coala#2330

sks444 added a commit to sks444/coala-bears that referenced this issue Apr 28, 2018

GitCommitBear.py: use giturlparse
This uses an external library for
fetching and parsing of remotes.

Closes coala#2330

sks444 added a commit to sks444/coala-bears that referenced this issue Apr 28, 2018

GitCommitBear.py: use giturlparse
This uses an external library for
fetching and parsing of remotes.

Closes coala#2330

sks444 added a commit to sks444/coala-bears that referenced this issue Apr 28, 2018

GitCommitBear: parse remote with giturlparse
This uses an external library for
fetching and parsing of remotes.

Closes coala#2330
@sks444 sks444 referenced this issue Apr 28, 2018
0 of 2 tasks complete

sks444 added a commit to sks444/coala-bears that referenced this issue Apr 29, 2018

GitCommitBear: Parse remote with giturlparse
This uses an external library for
parsing of remotes.

Closes coala#2330

gitmate-bot added a commit to sks444/coala-bears that referenced this issue Apr 30, 2018

GitCommitBear: Parse remote with giturlparse
This uses an external library for
parsing of remotes.

Closes coala#2330

virresh added a commit to virresh/coala-bears that referenced this issue May 8, 2018

HgCommitBear: Switch to git-url-parse
giturlparse is insufficient for some hg urls, so
switch to git-url-parse

Augments coala#2330

virresh added a commit to virresh/coala-bears that referenced this issue May 9, 2018

HgCommitBear: Switch to git-url-parse
giturlparse is insufficient for some hg urls, so
switch to git-url-parse

Augments coala#2330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.