Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint for travis yaml config file #294

Closed
SanketDG opened this issue Mar 27, 2016 · 11 comments · Fixed by #1879
Closed

lint for travis yaml config file #294

SanketDG opened this issue Mar 27, 2016 · 11 comments · Fixed by #1879

Comments

@SanketDG
Copy link
Member

https://github.com/pwmckenna/node-travis-lint

@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

@mr-karan
Copy link
Contributor

This linter has inconsistent error messages.

install:
script:
  - bash .ci/tests.sh

value for "install" section is empty, dropping

install
script:
  - bash .ci/tests.sh

syntax error: (<unknown>): could not find expected ':' while scanning a simple key at line 13 column 1

The line and col number is missing in the first error message

@sils
Copy link
Member

sils commented Mar 28, 2016

It probably has linting and parsing error messages

@mr-karan
Copy link
Contributor

Yep that's the case. Would make things difficult with regex

This is a better alternative: https://github.com/travis-ci/travis-yaml

@Nosferatul
Copy link
Member

@jayvdb
Copy link
Member

jayvdb commented Dec 17, 2016

https://github.com/pwmckenna/node-travis-lint uses https://github.com/pwmckenna/node-travis-ci to fetch lint results from the Travis CI web API.
And the Travis CI web API is likely to be using https://github.com/travis-ci/travis-yaml anyway, so yes we should be using the Ruby linter, not the Node wrapper.

@Mixih
Copy link
Member

Mixih commented Dec 17, 2016

I'm taking this for now. I'll be using travis's package then

@Mixih Mixih self-assigned this Dec 17, 2016
@Adrianzatreanu
Copy link
Contributor

@Mixih CC

@Makman2
Copy link
Member

Makman2 commented May 24, 2017

as no progress yet and it's part of @yash-nisar 's gsoc, reassigning to him :)

@Makman2 Makman2 assigned yash-nisar and unassigned Mixih May 24, 2017
@yash-nisar
Copy link
Member

https://docs.travis-ci.com/user/travis-lint has a precise explanation for the steps to be followed.
Sample output:

 ~  travis lint travis-yaml 
Warnings for travis-yaml:
[x] value for addons section is empty, dropping
[x] value for branches section is empty, dropping
[x] in addons section: unexpected key apt, dropping
[x] in branches section: unexpected key exclude, dropping

CC @jayvdb

@jayvdb
Copy link
Member

jayvdb commented May 31, 2017

@yash-nisar

~  travis lint travis-yaml

I assume you mean travis lint .travis.yml.

No doubt you have seen in your analysis that this bear fails for coala and coala-bears repos.

How valuable is this linter if it fails?

Have you looked into whether those bugs have been raised upstream?
Is it likely they will be fixed soon?

Should this bear wait until those fixes are completed?

Will you add arguments to disable some checks so that it can be used on our repos?

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 1, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 1, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 3, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 3, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 4, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 4, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 5, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
umeshksingla pushed a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

10 participants