New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint for travis yaml config file #294

Closed
SanketDG opened this Issue Mar 27, 2016 · 11 comments

Comments

10 participants
@SanketDG
Member

SanketDG commented Mar 27, 2016

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Mar 27, 2016

Collaborator

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

Collaborator

gitmate-bot commented Mar 27, 2016

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

@mr-karan

This comment has been minimized.

Show comment
Hide comment
@mr-karan

mr-karan Mar 28, 2016

Contributor

This linter has inconsistent error messages.

install:
script:
  - bash .ci/tests.sh

value for "install" section is empty, dropping

install
script:
  - bash .ci/tests.sh

syntax error: (<unknown>): could not find expected ':' while scanning a simple key at line 13 column 1

The line and col number is missing in the first error message

Contributor

mr-karan commented Mar 28, 2016

This linter has inconsistent error messages.

install:
script:
  - bash .ci/tests.sh

value for "install" section is empty, dropping

install
script:
  - bash .ci/tests.sh

syntax error: (<unknown>): could not find expected ':' while scanning a simple key at line 13 column 1

The line and col number is missing in the first error message

@sils

This comment has been minimized.

Show comment
Hide comment
@sils

sils Mar 28, 2016

Member

It probably has linting and parsing error messages

Member

sils commented Mar 28, 2016

It probably has linting and parsing error messages

@mr-karan

This comment has been minimized.

Show comment
Hide comment
@mr-karan

mr-karan Mar 28, 2016

Contributor

Yep that's the case. Would make things difficult with regex

This is a better alternative: https://github.com/travis-ci/travis-yaml

Contributor

mr-karan commented Mar 28, 2016

Yep that's the case. Would make things difficult with regex

This is a better alternative: https://github.com/travis-ci/travis-yaml

@Nosferatul

This comment has been minimized.

Show comment
Hide comment
Member

Nosferatul commented Dec 14, 2016

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Dec 17, 2016

Member

https://github.com/pwmckenna/node-travis-lint uses https://github.com/pwmckenna/node-travis-ci to fetch lint results from the Travis CI web API.
And the Travis CI web API is likely to be using https://github.com/travis-ci/travis-yaml anyway, so yes we should be using the Ruby linter, not the Node wrapper.

Member

jayvdb commented Dec 17, 2016

https://github.com/pwmckenna/node-travis-lint uses https://github.com/pwmckenna/node-travis-ci to fetch lint results from the Travis CI web API.
And the Travis CI web API is likely to be using https://github.com/travis-ci/travis-yaml anyway, so yes we should be using the Ruby linter, not the Node wrapper.

@Mixih

This comment has been minimized.

Show comment
Hide comment
@Mixih

Mixih Dec 17, 2016

Member

I'm taking this for now. I'll be using travis's package then

Member

Mixih commented Dec 17, 2016

I'm taking this for now. I'll be using travis's package then

@Mixih Mixih self-assigned this Dec 17, 2016

@Adrianzatreanu

This comment has been minimized.

Show comment
Hide comment
@Adrianzatreanu
Contributor

Adrianzatreanu commented Apr 22, 2017

@Mixih CC

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 May 24, 2017

Member

as no progress yet and it's part of @yash-nisar 's gsoc, reassigning to him :)

Member

Makman2 commented May 24, 2017

as no progress yet and it's part of @yash-nisar 's gsoc, reassigning to him :)

@Makman2 Makman2 assigned yash-nisar and unassigned Mixih May 24, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar May 26, 2017

Member

https://docs.travis-ci.com/user/travis-lint has a precise explanation for the steps to be followed.
Sample output:

 ~  travis lint travis-yaml 
Warnings for travis-yaml:
[x] value for addons section is empty, dropping
[x] value for branches section is empty, dropping
[x] in addons section: unexpected key apt, dropping
[x] in branches section: unexpected key exclude, dropping

CC @jayvdb

Member

yash-nisar commented May 26, 2017

https://docs.travis-ci.com/user/travis-lint has a precise explanation for the steps to be followed.
Sample output:

 ~  travis lint travis-yaml 
Warnings for travis-yaml:
[x] value for addons section is empty, dropping
[x] value for branches section is empty, dropping
[x] in addons section: unexpected key apt, dropping
[x] in branches section: unexpected key exclude, dropping

CC @jayvdb

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb May 31, 2017

Member

@yash-nisar

~  travis lint travis-yaml

I assume you mean travis lint .travis.yml.

No doubt you have seen in your analysis that this bear fails for coala and coala-bears repos.

How valuable is this linter if it fails?

Have you looked into whether those bugs have been raised upstream?
Is it likely they will be fixed soon?

Should this bear wait until those fixes are completed?

Will you add arguments to disable some checks so that it can be used on our repos?

Member

jayvdb commented May 31, 2017

@yash-nisar

~  travis lint travis-yaml

I assume you mean travis lint .travis.yml.

No doubt you have seen in your analysis that this bear fails for coala and coala-bears repos.

How valuable is this linter if it fails?

Have you looked into whether those bugs have been raised upstream?
Is it likely they will be fixed soon?

Should this bear wait until those fixes are completed?

Will you add arguments to disable some checks so that it can be used on our repos?

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 1, 2017

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 1, 2017

@yash-nisar yash-nisar referenced this issue Jul 1, 2017

Merged

bears/yaml: Add TravisLintBear #1879

2 of 2 tasks complete

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 3, 2017

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 3, 2017

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 4, 2017

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 4, 2017

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 5, 2017

@rultor rultor closed this in #1879 Jul 5, 2017

gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017

umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment