Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Fedora 23-25 package pmd jars #804

Open
jayvdb opened this issue Sep 9, 2016 · 7 comments
Open

Detect Fedora 23-25 package pmd jars #804

jayvdb opened this issue Sep 9, 2016 · 7 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Sep 9, 2016

Fedora package pmd is provided on Fedora 23+, but it only provides the jars, and does not include a pmd script.

As a result coala complains, and recommends installing pmd.

It would be nice if coala found and ran the jars.

@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

@sils
Copy link
Member

sils commented Sep 9, 2016

Hm, how are the jars run? Directly? I don't have a fedora around, but this should be simple. Would be willing to help?

@jayvdb
Copy link
Member Author

jayvdb commented Sep 9, 2016

I am guessing pmd is a simple shell script. If so, paste it here and I'll try to run it, and then figure out the oneliner needed to run it in coala.

@sils
Copy link
Member

sils commented Sep 9, 2016

Hm it's not a oneliner... http://pastebin.com/iMTGVNgs

@jayvdb
Copy link
Member Author

jayvdb commented Sep 10, 2016

Thanks. Found the source here : https://github.com/pmd/pmd/blob/master/pmd-dist/src/main/scripts/run.sh

@jayvdb jayvdb changed the title Detect Fedora package pmd jars Detect Fedora 23+ package pmd jars Sep 10, 2016
@jayvdb
Copy link
Member Author

jayvdb commented Sep 10, 2016

I've raised the bug upstream, so hopefully this will "just work" in the future:
https://bugzilla.redhat.com/show_bug.cgi?id=1374887

It is a bit of a pain to build pmd manually, as toolchains.xml needs to be created manually on Fedora, and then maven wants jdk 1.7, but Fedora provides jdk 1.8 only.
I worked around this by using dnf copr enable jschwart/openjdk-7 .
It is likely that pmd works on jdk 8, since Fedora pmd package is using a jdk and only jdk 8 is available.

@jayvdb
Copy link
Member Author

jayvdb commented Apr 26, 2017

I've raised the bug upstream, so hopefully this will "just work" in the future:
https://bugzilla.redhat.com/show_bug.cgi?id=1374887

Closed wontfix, as component pmd has been retired in Fedora 26, and the last RPM is pmd-5.5.0-2.fc25.src.rpm.

@jayvdb jayvdb changed the title Detect Fedora 23+ package pmd jars Detect Fedora 23-25 package pmd jars Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants