New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/stylus: Add StylintBear #1610

Merged
merged 1 commit into from Jun 4, 2017

Conversation

5 participants
@yash-nisar
Member

yash-nisar commented Apr 16, 2017

Closes #754

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Apr 16, 2017

Member

@Makman2 @jayvdb Should we try to include this in the next release ?

Member

yash-nisar commented Apr 16, 2017

@Makman2 @jayvdb Should we try to include this in the next release ?

@jayvdb

Unlikely to be able to get new bear PRs through code review by the next release. Lots of design work. More likely to get old bear PRs in.

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Apr 23, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Apr 23, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@jayvdb

needs tests regarding standard settings, such as tabs&spaces, indents, spaces at end of line, and line length.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Apr 26, 2017

Member

Is the StylintBear.py file good @jayvdb ?

Member

yash-nisar commented Apr 26, 2017

Is the StylintBear.py file good @jayvdb ?

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot May 4, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 4, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

4 similar comments
@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot May 11, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 11, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot May 18, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 18, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot May 18, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 18, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot May 25, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented May 25, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated

@gitmate-bot gitmate-bot added size/XXL and removed size/XL labels May 31, 2017

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 1, 2017

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
- Unnecessary brackets
- Missing colon between property and value
- Naming conventions
- Trailing whitespace

This comment has been minimized.

@Makman2

Makman2 Jun 1, 2017

Member

some more advanced features maybe too?

@Makman2

Makman2 Jun 1, 2017

Member

some more advanced features maybe too?

This comment has been minimized.

@yash-nisar

yash-nisar Jun 2, 2017

Member

Done.

@yash-nisar

yash-nisar Jun 2, 2017

Member

Done.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 2, 2017

Show outdated Hide outdated tests/stylus/StylintBearTest.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 4, 2017

Updated @Makman2

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jun 4, 2017

ack 47d3956

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jun 4, 2017

Member

@rultor merge

Member

Makman2 commented Jun 4, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 4, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jun 4, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 47d3956 into coala:master Jun 4, 2017

6 of 9 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 4, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Jun 4, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment