New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StylintBear: Implement settings #1796

Merged
merged 1 commit into from Jun 13, 2017

Conversation

4 participants
@yash-nisar
Member

yash-nisar commented Jun 1, 2017

Use the implemented settings to generate a config_file and use
that file if the user does not explicitly mention stylint_config.

Closes #1795

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 1, 2017

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 2, 2017

Member

CC @Makman2 , blocked until we get the StylintBear merged.

Member

yash-nisar commented Jun 2, 2017

CC @Makman2 , blocked until we get the StylintBear merged.

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 2, 2017

Updated @Makman2

1 similar comment
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 3, 2017

Updated @Makman2

@gitmate-bot gitmate-bot added size/L and removed size/XXL labels Jun 4, 2017

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
indent with spaces this is the number of spaces you indent with.
If you use hard tabs, set this value to ``0``.
For example: If set to ``2``, prefer
``/s/smargin: 0`` over ``/s/s/smargin: 0``.

This comment has been minimized.

@Makman2

Makman2 Jun 9, 2017

Member

are those /s rendered as whitespaces?

@Makman2

Makman2 Jun 9, 2017

Member

are those /s rendered as whitespaces?

This comment has been minimized.

@yash-nisar

yash-nisar Jun 9, 2017

Member

Nope, this is just so the user can differenciate between tabs and spaces and see how the setting works.

@yash-nisar

yash-nisar Jun 9, 2017

Member

Nope, this is just so the user can differenciate between tabs and spaces and see how the setting works.

This comment has been minimized.

@Makman2

Makman2 Jun 13, 2017

Member

Hm alright, fine with me 👍 I think this should be readable 👍

@Makman2

Makman2 Jun 13, 2017

Member

Hm alright, fine with me 👍 I think this should be readable 👍

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
spaces_inside_parentheses: bool=None,
placeholder: bool=True,
prefix_vars_with_dollar: bool=True,
semicolons: bool=False,

This comment has been minimized.

@Makman2

Makman2 Jun 9, 2017

Member

What's a common default? Maybe we should make it None? Don't know what's best practice for stylint^^

@Makman2

Makman2 Jun 9, 2017

Member

What's a common default? Maybe we should make it None? Don't know what's best practice for stylint^^

This comment has been minimized.

@yash-nisar

yash-nisar Jun 9, 2017

Member

This comment has been minimized.

@Makman2

Makman2 Jun 9, 2017

Member

Alright, if someone doesn't want to check semicolons at all, he/she shall open an issue :P

@Makman2

Makman2 Jun 9, 2017

Member

Alright, if someone doesn't want to check semicolons at all, he/she shall open an issue :P

This comment has been minimized.

@yash-nisar

yash-nisar Jun 11, 2017

Member

Also, see http://stylus-lang.com/docs/css-style.html#example where they don't use semicolons (and have mentioned it as optional).

@yash-nisar

yash-nisar Jun 11, 2017

Member

Also, see http://stylus-lang.com/docs/css-style.html#example where they don't use semicolons (and have mentioned it as optional).

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 11, 2017

Updated @Makman2

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
color red !important
:param spaces_inside_parentheses:
Enforce or disallow use of extra spaces inside parentheses.

This comment has been minimized.

@Makman2

Makman2 Jun 13, 2017

Member

hm maybe an example when extra space is enforced and one when it's disallowed?

@Makman2

Makman2 Jun 13, 2017

Member

hm maybe an example when extra space is enforced and one when it's disallowed?

This comment has been minimized.

@yash-nisar

yash-nisar Jun 13, 2017

Member

Example added.

@yash-nisar

yash-nisar Jun 13, 2017

Member

Example added.

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
mixed_spaces_and_tabs: bool=False,
variable_naming_convention: str=None,
strict_naming_convention: bool=False,
none_keyword: bool=False,

This comment has been minimized.

@Makman2

Makman2 Jun 13, 2017

Member

not sure, is this value a developer preference? If so we should maybe make it to None

@Makman2

Makman2 Jun 13, 2017

Member

not sure, is this value a developer preference? If so we should maybe make it to None

This comment has been minimized.

@yash-nisar

yash-nisar Jun 13, 2017

Member
prefix_vars_with_dollar: bool=True,
semicolons: bool=False,
sort_order: str='alphabetical',
stacked_properties: bool=False,

This comment has been minimized.

@Makman2

Makman2 Jun 13, 2017

Member

Is this one a developer preference? I can also assume that many people do mix them if the properties are simple^^ (if my idea of a property is the same like a property in Stylint)

@Makman2

Makman2 Jun 13, 2017

Member

Is this one a developer preference? I can also assume that many people do mix them if the properties are simple^^ (if my idea of a property is the same like a property in Stylint)

This comment has been minimized.

@yash-nisar

yash-nisar Jun 13, 2017

Member
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 13, 2017

Member

@Makman2 Updated.

Member

yash-nisar commented Jun 13, 2017

@Makman2 Updated.

Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
Show outdated Hide outdated bears/stylus/StylintBear.py Outdated
StylintBear: Implement settings
Use the implemented settings to generate a `config_file` and use
that file if the user does not explicitly mention `stylint_config`.

Closes #1795
@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jun 13, 2017

ack e4a9d34

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jun 13, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 13, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jun 13, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e4a9d34 into coala:master Jun 13, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 13, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Jun 13, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:stylint-settings branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment