New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubocopBear: Optional generation of `config_file` #1841

Merged
merged 1 commit into from Jun 15, 2017

Conversation

5 participants
@yash-nisar
Member

yash-nisar commented Jun 14, 2017

Generation of config_file is only done if rubocop_config is
absent as an argument. This is a performance gain since
config_file was generated irrespective of rubocop_config,
each time the bear was run.

Closes #1839

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 14, 2017

Member

@Makman2 review required. 😉

Member

yash-nisar commented Jun 14, 2017

@Makman2 review required. 😉

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jun 14, 2017

ack e5194d9

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jun 14, 2017

Member

Rebase and language-check should hopefully install again so CI passes 👍 :)

Member

Makman2 commented Jun 14, 2017

Rebase and language-check should hopefully install again so CI passes 👍 :)

@jayvdb

Why are there no tests?
How do you know this works?
And it looks like you might be solving #1077

More broadly, is this a performance problem affecting all bears that use a config file?
Is it documented that bears should do this when they have a config file?
Is this the only bear which doesnt do it?

See coala/coala#4072 for my initial attempt at trying to find a way to make config files a native part of the Linter class.

Show outdated Hide outdated bears/ruby/RuboCopBear.py Outdated
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 15, 2017

Member

There are tests where we provide a custom config_file as well as generate one. Moreover, we have tested it manually so it does work. Yes, it is a performance problem for all bears that use a config_file. CC @jayvdb

Member

yash-nisar commented Jun 15, 2017

There are tests where we provide a custom config_file as well as generate one. Moreover, we have tested it manually so it does work. Yes, it is a performance problem for all bears that use a config_file. CC @jayvdb

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 15, 2017

Member

There has been a discussion on this before and an issue has been created, see coala/coala#4119 and see #1615 (comment) for the analysis that I had done.

Member

yash-nisar commented Jun 15, 2017

There has been a discussion on this before and an issue has been created, see coala/coala#4119 and see #1615 (comment) for the analysis that I had done.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 15, 2017

Member

See coala/coala#4119 (comment) for a detailed explanation and there is an ongoing PR for this too -> coala/coala#4241

Member

yash-nisar commented Jun 15, 2017

See coala/coala#4119 (comment) for a detailed explanation and there is an ongoing PR for this too -> coala/coala#4241

RubocopBear: Optional generation of `config_file`
Generation of `config_file` is only done if `rubocop_config` is
absent as an argument. This is a performance gain since
`config_file` was generated irrespective of `rubocop_config`,
each time the bear was run.

Closes #1839
@jayvdb

jayvdb approved these changes Jun 15, 2017

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb
Member

jayvdb commented Jun 15, 2017

ack 45dfb62

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Jun 15, 2017

Member

@rultor merge

Member

jayvdb commented Jun 15, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 15, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jun 15, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 45dfb62 into coala:master Jun 15, 2017

6 of 9 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 15, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

rultor commented Jun 15, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:rubocop-perf branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment