New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/c_languages: Add ArtisticStyleBear #1882

Merged
merged 1 commit into from Jul 21, 2017

Conversation

7 participants
@yash-nisar
Member

yash-nisar commented Jul 3, 2017

Closes #388

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Show outdated Hide outdated .ci/deps.sh
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
bar()
return 1; }
else
return 0; }

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

can you shorten this... maybe providing us the list of all ppossible values for this settting along with fewer examples and more tests would do the trick.

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

can you shorten this... maybe providing us the list of all ppossible values for this settting along with fewer examples and more tests would do the trick.

This comment has been minimized.

@Makman2

Makman2 Jul 10, 2017

Member

I actually don't have something against this longer documentation, but we definitely need some header line that summarizes the possible values and their meanings in a few sentences 👍

@Makman2

Makman2 Jul 10, 2017

Member

I actually don't have something against this longer documentation, but we definitely need some header line that summarizes the possible values and their meanings in a few sentences 👍

Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
........bar();
}
For example: If set to ``True``, spaces will be used for

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

If True spaces will be used.
Example:: (should be a code if not example is not needed

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

If True spaces will be used.
Example:: (should be a code if not example is not needed

For example: If set to ``True``, spaces will be used for
indentation.
For example: If set to ``False``, tabs will be used for
indentation, and spaces for continuation line alignment as below::

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

same here

@AsnelChristian

AsnelChristian Jul 4, 2017

Member

same here

Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 6, 2017

Member

@Makman2 Please have a look when you're free 😉

Member

yash-nisar commented Jul 6, 2017

@Makman2 Please have a look when you're free 😉

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 6, 2017

Member

Can you help me out with the appveyor build failure ? @Makman2

Member

yash-nisar commented Jul 6, 2017

Can you help me out with the appveyor build failure ? @Makman2

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 6, 2017

Member

An uncached CircleCI build passes whereas a cached build fails. Note that TravisCI builds pass.

Member

yash-nisar commented Jul 6, 2017

An uncached CircleCI build passes whereas a cached build fails. Note that TravisCI builds pass.

Show outdated Hide outdated .ci/deps.sh
Show outdated Hide outdated .ci/deps.sh
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 11, 2017

Member

@Makman2 How do the changes look now ?

Member

yash-nisar commented Jul 11, 2017

@Makman2 How do the changes look now ?

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jul 11, 2017

Member

@yash-nisar your tests fail :O

Member

Makman2 commented Jul 11, 2017

@yash-nisar your tests fail :O

Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
#endif
:param allow_indent_classes:
Indent ``class`` and ``struct`` blocks so that the entire block is

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 18, 2017

Member

is the indentation size used here provided by indent_size

@AsnelChristian

AsnelChristian Jul 18, 2017

Member

is the indentation size used here provided by indent_size

Show outdated Hide outdated bears/c_languages/ArtisticStyleBear.py
Show outdated Hide outdated .ci/deps.sh
Show outdated Hide outdated .ci/deps.sh
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 20, 2017

Member

@Makman2 Did you notice that the tests have passed and we have no idea why ? 😛

Member

yash-nisar commented Jul 20, 2017

@Makman2 Did you notice that the tests have passed and we have no idea why ? 😛

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 20, 2017

Member

They pass whenever they want to. 😛

Member

yash-nisar commented Jul 20, 2017

They pass whenever they want to. 😛

Possible values are ``allman, java, kr, stroustrup, whitesmith,
vtk, banner, gnu, linux, horstmann, google, mozilla, pico and
lisp.``
For example: Allman style uses braces that are broken from the

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 20, 2017

Member
``Allman style``
@AsnelChristian

AsnelChristian Jul 20, 2017

Member
``Allman style``

This comment has been minimized.

@Makman2

Makman2 Jul 20, 2017

Member

Hm not sure, then rather

``allman`` style

to refer to the actual keyword/parameter

@Makman2

Makman2 Jul 20, 2017

Member

Hm not sure, then rather

``allman`` style

to refer to the actual keyword/parameter

This comment has been minimized.

@yash-nisar

yash-nisar Jul 21, 2017

Member

See #1882 (comment). Referring to the actual keyword/parameter may cause problems in some cases like Kernighan & Ritchie. The actual keyword is referred to as kr so replacing Kernighan & Ritchie with kr may make it difficult for users to understand the style name.

@yash-nisar

yash-nisar Jul 21, 2017

Member

See #1882 (comment). Referring to the actual keyword/parameter may cause problems in some cases like Kernighan & Ritchie. The actual keyword is referred to as kr so replacing Kernighan & Ritchie with kr may make it difficult for users to understand the style name.

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian

AsnelChristian Jul 20, 2017

Member

aren't they passing locally ?

Member

AsnelChristian commented Jul 20, 2017

aren't they passing locally ?

@Nosferatul

This comment has been minimized.

Show comment
Hide comment
@Nosferatul

Nosferatul Jul 20, 2017

Member

@yash-nisar why the tests have passed because of your tests, right?

Member

Nosferatul commented Jul 20, 2017

@yash-nisar why the tests have passed because of your tests, right?

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jul 20, 2017

Member

@AsnelChristian we had strange caching problems. Cached runs just didn't pass, although everything seemed to be set up correctly (we did the same like for other applications). However we will file an issue to implement caching again, so we can at least get something merged.

Member

Makman2 commented Jul 20, 2017

@AsnelChristian we had strange caching problems. Cached runs just didn't pass, although everything seemed to be set up correctly (we did the same like for other applications). However we will file an issue to implement caching again, so we can at least get something merged.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 21, 2017

Member

Updated with the required changes @Makman2 @AsnelChristian

Member

yash-nisar commented Jul 21, 2017

Updated with the required changes @Makman2 @AsnelChristian

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 21, 2017

Member

Lets see if the tests pass on CI, if they don't I'll remove the if condition in deps.sh.

Member

yash-nisar commented Jul 21, 2017

Lets see if the tests pass on CI, if they don't I'll remove the if condition in deps.sh.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 21, 2017

Member

Bam The problem is now gone 👍 @Makman2

Member

yash-nisar commented Jul 21, 2017

Bam The problem is now gone 👍 @Makman2

break_one_line_headers: bool=False,
require_braces_at_one_line_conditionals: bool=False,
prohibit_braces_from_one_line_conditionals:
bool=False,

This comment has been minimized.

@Makman2

Makman2 Jul 21, 2017

Member

indent by 4 spaces

this is invalid PEP8 it seems

@Makman2

Makman2 Jul 21, 2017

Member

indent by 4 spaces

this is invalid PEP8 it seems

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 21, 2017

ack 65d6304

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 21, 2017

ack 65d6304

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 21, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jul 21, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 65d6304 into coala:master Jul 21, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@yash-nisar yash-nisar deleted the yash-nisar:astyle-bear branch Jul 21, 2017

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Jul 21, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment