Skip to content

MarkdownBear: Replace markdown_horizontal_rule #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

yash-nisar
Copy link
Member

@yash-nisar yash-nisar commented Jul 9, 2017

Replace markdown_horizontal_rule in the docstring by
horizontal_rule which is used create_arguments(...).

Closes #1907

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar
Copy link
Member Author

CC @Makman2 , a quick one 😉

@Makman2
Copy link
Member

Makman2 commented Jul 10, 2017

ack e043a2e

Replace `markdown_horizontal_rule` in the docstring by
`horizontal_rule` which is used `create_arguments(...)`.

Closes coala#1907
@yash-nisar
Copy link
Member Author

reack e2cf115

@Makman2
Copy link
Member

Makman2 commented Jul 10, 2017

@rultor merge

@rultor
Copy link

rultor commented Jul 10, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e2cf115 into coala:master Jul 10, 2017
@yash-nisar yash-nisar deleted the change-arg branch July 10, 2017 14:37
@rultor
Copy link

rultor commented Jul 10, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

MarkdownBear: Replace markdown_horizontal_rule
4 participants