New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkdownBear: Replace `markdown_horizontal_rule` #1908

Merged
merged 1 commit into from Jul 10, 2017

Conversation

4 participants
@yash-nisar
Member

yash-nisar commented Jul 9, 2017

Replace markdown_horizontal_rule in the docstring by
horizontal_rule which is used create_arguments(...).

Closes #1907

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 9, 2017

Member

CC @Makman2 , a quick one 😉

Member

yash-nisar commented Jul 9, 2017

CC @Makman2 , a quick one 😉

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 10, 2017

ack e043a2e

MarkdownBear: Replace `markdown_horizontal_rule`
Replace `markdown_horizontal_rule` in the docstring by
`horizontal_rule` which is used `create_arguments(...)`.

Closes #1907
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 10, 2017

reack e2cf115

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 10, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 10, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jul 10, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e2cf115 into coala:master Jul 10, 2017

6 of 9 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@yash-nisar yash-nisar deleted the yash-nisar:change-arg branch Jul 10, 2017

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 10, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Jul 10, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment