New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/pug: Add PugLintBear #1936

Merged
merged 1 commit into from Jul 21, 2017

Conversation

8 participants
@yash-nisar
Member

yash-nisar commented Jul 17, 2017

Closes #290

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 17, 2017

div
div

This comment has been minimized.

@Makman2

Makman2 Jul 17, 2017

Member

are the missing \n at EOF on purpose?

@Makman2

Makman2 Jul 17, 2017

Member

are the missing \n at EOF on purpose?

This comment has been minimized.

@yash-nisar

yash-nisar Jul 18, 2017

Member

Nope, my bad.

@yash-nisar

yash-nisar Jul 18, 2017

Member

Nope, my bad.

This comment has been minimized.

@yash-nisar

yash-nisar Jul 18, 2017

Member

Fixed. 👍

@yash-nisar

yash-nisar Jul 18, 2017

Member

Fixed. 👍

Show outdated Hide outdated bears/pug/PugLintBear.py
Show outdated Hide outdated bears/pug/PugLintBear.py
For example: If set to ``True``, prefer
``input(type='text').class`` over ``input.class(type='text')``.
:param prohibit_class_literals_before_id_literals:
When ``True``, prefer all ID literals to be written before any

This comment has been minimized.

@AsnelChristian
@AsnelChristian
Show outdated Hide outdated bears/pug/PugLintBear.py
Show outdated Hide outdated bears/pug/PugLintBear.py
Show outdated Hide outdated bears/pug/PugLintBear.py
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 18, 2017

Updated @Makman2

When ``True``, prefer all attribute blocks to be written before
any class literals.
For example: If set to ``True``, prefer
``input(type='text').class`` over ``input.class(type='text')``.

This comment has been minimized.

@Makman2

Makman2 Jul 18, 2017

Member

what's with enforcing the other way around?

@Makman2

Makman2 Jul 18, 2017

Member

what's with enforcing the other way around?

"requireClassLiteralsBeforeIdLiterals":false,
"validateDivTags":true,
"disallowTagInterpolation":true
}

This comment has been minimized.

@yash-nisar

yash-nisar Jul 18, 2017

Member

Ah, eof damnit.

@yash-nisar

yash-nisar Jul 18, 2017

Member

Ah, eof damnit.

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian

AsnelChristian Jul 18, 2017

Member
Member

AsnelChristian commented Jul 18, 2017

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian

AsnelChristian Jul 18, 2017

Member
Member

AsnelChristian commented Jul 18, 2017

``input.class#id(type='text')``.
:param prohibit_class_literals:
When ``True``, disallow any class literals.
For example: If set to ``True``, prefer ``div(class='class')``

This comment has been minimized.

@AsnelChristian

AsnelChristian Jul 19, 2017

Member

i am kind of lost prohibit_class_attribute_with_static_value default value is True so you make use of class literals but here prohibit_class_literals you prohibit them.... isn't that contradicting?

@AsnelChristian

AsnelChristian Jul 19, 2017

Member

i am kind of lost prohibit_class_attribute_with_static_value default value is True so you make use of class literals but here prohibit_class_literals you prohibit them.... isn't that contradicting?

This comment has been minimized.

@yash-nisar

yash-nisar Jul 19, 2017

Member

Fixed 👍

@yash-nisar

yash-nisar Jul 19, 2017

Member

Fixed 👍

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 19, 2017

Member

One weird thing that I noticed was that the config (which is later converted to json) only takes the values true and null, so I've made the required changes.

Member

yash-nisar commented Jul 19, 2017

One weird thing that I noticed was that the config (which is later converted to json) only takes the values true and null, so I've made the required changes.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 19, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 20, 2017

Member

@Makman2 Updated.

Member

yash-nisar commented Jul 20, 2017

@Makman2 Updated.

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian
Member

AsnelChristian commented Jul 20, 2017

👍

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian
Member

AsnelChristian commented Jul 20, 2017

ack 4cfe907

@AsnelChristian

This comment has been minimized.

Show comment
Hide comment
@AsnelChristian
Member

AsnelChristian commented Jul 20, 2017

@Makman2 ping! 😄

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jul 20, 2017

Member

@AsnelChristian bam! 💥
thanks for reviewing :D
rebase and lgtm @yash-nisar :)

Member

Makman2 commented Jul 20, 2017

@AsnelChristian bam! 💥
thanks for reviewing :D
rebase and lgtm @yash-nisar :)

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 21, 2017

reack 1d31827

@sils

This comment has been minimized.

Show comment
Hide comment
@sils

sils Jul 21, 2017

Member

@rultor merge

Member

sils commented Jul 21, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2017

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jul 21, 2017

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1d31827 into coala:master Jul 21, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@yash-nisar yash-nisar deleted the yash-nisar:pug-bear branch Jul 21, 2017

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 21, 2017

@rultor merge

@sils Done! FYI, the full log is here (took me 2min)

rultor commented Jul 21, 2017

@rultor merge

@sils Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment