New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentationStyleBear: Add expand_one_liners #1940

Merged
merged 1 commit into from Jul 24, 2017

Conversation

4 participants
@damngamerz
Member

damngamerz commented Jul 22, 2017

Add expand_one_liners setting which will expand one
liners to multi line docstring.

Closes #1856

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

DocumentationStyleBear: Add expand_one_liners
Add expand_one_liners setting which will expand one
liners to multi line docstring.

Closes #1856
@SanketDG

This comment has been minimized.

Member

SanketDG commented Jul 22, 2017

ack 40cd086

@SanketDG

This comment has been minimized.

Member

SanketDG commented Jul 24, 2017

@rultor merge

@rultor

This comment has been minimized.

rultor commented Jul 24, 2017

@rultor merge

@SanketDG OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 40cd086 into coala:master Jul 24, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

rultor commented Jul 24, 2017

@rultor merge

@SanketDG Done! FYI, the full log is here (took me 2min)

@damngamerz damngamerz deleted the damngamerz:oneliner branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment