New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/css: Add CSSCombBear #1957

Merged
merged 1 commit into from Jul 29, 2017

Conversation

5 participants
@yash-nisar
Member

yash-nisar commented Jul 27, 2017

Closes #634

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 27, 2017

{
"space-after-opening-brace": 1,
"space-before-closing-brace": 1
}

This comment has been minimized.

@Makman2

Makman2 Jul 28, 2017

Member

no newline on purpose?

@Makman2

Makman2 Jul 28, 2017

Member

no newline on purpose?

This comment has been minimized.

@yash-nisar

yash-nisar Jul 28, 2017

Member

Somewhere at the back of my mind I had the newline fear, but failed to review myself. My bad.

@yash-nisar

yash-nisar Jul 28, 2017

Member

Somewhere at the back of my mind I had the newline fear, but failed to review myself. My bad.

prohibit_units_in_zero_valued_dimensions: bool=True,
vendor_prefix_align: bool=None,
use_lines_between_rulesets: int=1,
csscomb_config: str=''):

This comment has been minimized.

@Makman2

Makman2 Jul 28, 2017

Member

csscomb_config is not documented

@Makman2

Makman2 Jul 28, 2017

Member

csscomb_config is not documented

This comment has been minimized.

@Makman2

Makman2 Jul 28, 2017

Member

nvm

@Makman2

Makman2 Jul 28, 2017

Member

nvm

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jul 28, 2017

Member

you don't have test files, so you don't need to place a __init__.py into a test directory without python files 👍

Member

Makman2 commented Jul 28, 2017

you don't have test files, so you don't need to place a __init__.py into a test directory without python files 👍

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 29, 2017

Updated @Makman2

@Nosferatul

This comment has been minimized.

Show comment
Hide comment
@Nosferatul

Nosferatul Jul 29, 2017

Member

nice @yash-nisar 👍 documented, clean code.

Member

Nosferatul commented Jul 29, 2017

nice @yash-nisar 👍 documented, clean code.

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 29, 2017

ack 2bef3df

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 29, 2017

ack 2bef3df

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Jul 29, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 29, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jul 29, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2bef3df into coala:master Jul 29, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 29, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Jul 29, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:csscomb branch Jul 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment