Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/css: Add CSSCombBear #1957

Merged
merged 1 commit into from Jul 29, 2017
Merged

bears/css: Add CSSCombBear #1957

merged 1 commit into from Jul 29, 2017

Conversation

yash-nisar
Copy link
Member

@yash-nisar yash-nisar commented Jul 27, 2017

Closes #634

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar
Copy link
Member Author

CC @Nosferatul @Makman2

{
"space-after-opening-brace": 1,
"space-before-closing-brace": 1
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere at the back of my mind I had the newline fear, but failed to review myself. My bad.

prohibit_units_in_zero_valued_dimensions: bool=True,
vendor_prefix_align: bool=None,
use_lines_between_rulesets: int=1,
csscomb_config: str=''):
Copy link
Member

@Makman2 Makman2 Jul 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csscomb_config is not documented

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm



@generate_skip_decorator(CSSCombBear)
class ArtisticStyleBearTest(LocalBearTestHelper):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test name ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, the copy paste bug.

@Makman2
Copy link
Member

Makman2 commented Jul 28, 2017

you don't have test files, so you don't need to place a __init__.py into a test directory without python files 👍

@yash-nisar
Copy link
Member Author

Updated @Makman2

@Nosferatul
Copy link
Member

nice @yash-nisar 👍 documented, clean code.

@Makman2
Copy link
Member

Makman2 commented Jul 29, 2017

ack 2bef3df

@Makman2
Copy link
Member

Makman2 commented Jul 29, 2017

ack 2bef3df

@Makman2
Copy link
Member

Makman2 commented Jul 29, 2017

@rultor merge

@rultor
Copy link

rultor commented Jul 29, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2bef3df into coala:master Jul 29, 2017
@rultor
Copy link

rultor commented Jul 29, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the csscomb branch July 30, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add CSSCombBear for CSS
5 participants