New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/hypertext: Add HTTPoliceLintBear.py #1962

Merged
merged 1 commit into from Aug 2, 2017

Conversation

4 participants
@yash-nisar
Member

yash-nisar commented Jul 31, 2017

Closes #596

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 31, 2017

@@ -0,0 +1,37 @@
{
"_warning": "This is not a real HAR file! It only contains the keys that are interesting to HTTPolice. Please do not use this as an example of a valid HAR file.",

This comment has been minimized.

@Makman2

Makman2 Jul 31, 2017

Member

do you maybe have at least one real HAR file?

@Makman2

Makman2 Jul 31, 2017

Member

do you maybe have at least one real HAR file?

This comment has been minimized.

@yash-nisar

yash-nisar Aug 1, 2017

Member

Yes, I have collected a real valid HAR file manually, will update the tests.

@yash-nisar

yash-nisar Aug 1, 2017

Member

Yes, I have collected a real valid HAR file manually, will update the tests.

This comment has been minimized.

@yash-nisar

yash-nisar Aug 1, 2017

Member

test_valid_file has a real HAR file 😄

@yash-nisar

yash-nisar Aug 1, 2017

Member

test_valid_file has a real HAR file 😄

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 1, 2017

Member

@Makman2 Updated.

Member

yash-nisar commented Aug 1, 2017

@Makman2 Updated.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Aug 2, 2017

Updated @Makman2

:param httpolice_silence_ids:
Silences the given list of notice IDs. You can get more information
about the available notices and their IDs at
https://httpolice.readthedocs.io/en/stable/notices.html.

This comment has been minimized.

@Makman2

Makman2 Aug 2, 2017

Member

since it's RST, is a special syntax required for links?

@Makman2

Makman2 Aug 2, 2017

Member

since it's RST, is a special syntax required for links?

This comment has been minimized.

@Makman2

Makman2 Aug 2, 2017

Member

no it works fine :)

@Makman2

Makman2 Aug 2, 2017

Member

no it works fine :)

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Aug 2, 2017

ack 40dd5d4

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Aug 2, 2017

ack 40dd5d4

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 2, 2017

Member

@rultor merge

Member

Makman2 commented Aug 2, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Aug 2, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Aug 2, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 40dd5d4 into coala:master Aug 2, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@yash-nisar yash-nisar deleted the yash-nisar:httpolice branch Aug 2, 2017

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Aug 2, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 3min)

rultor commented Aug 2, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment