/coala-bears

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears/hypertext: Add HTMLHintBear #1987

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Reviewers

@Makman2 Makman2

@SanketDG SanketDG

Assignees
No one assigned
Labels
Milestone
No milestone
6 participants
@yash-nisar @SanketDG @Makman2 @rultor @gitmate-bot @co-robo
@yash-nisar
Member

yash-nisar commented Aug 10, 2017 •
edited

Add HTMLHintBear that was worked upon by @AsnelChristian.
This PR is a continuation of @AsnelChristian's PR with some
modifications.

Closes #635

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.     It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@gitmate-bot gitmate-bot added process/pending review size/XL labels Aug 10, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 10, 2017

Member

CC @Makman2
Member

yash-nisar commented Aug 10, 2017

CC @Makman2

@yash-nisar yash-nisar changed the title from bears/hypertext: Add HTMLHintBear to WIP bears/hypertext: Add HTMLHintBear Aug 10, 2017

@gitmate-bot gitmate-bot added process/wip review carefully! and removed process/pending review labels Aug 10, 2017

@yash-nisar yash-nisar changed the title from WIP bears/hypertext: Add HTMLHintBear to bears/hypertext: Add HTMLHintBear Aug 10, 2017

@co-robo co-robo added process/pending review and removed process/wip labels Aug 10, 2017

Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
@SanketDG

This comment has been minimized.

Show comment
Hide comment
@SanketDG

SanketDG Aug 12, 2017

Member

@yash-nisar it should be '(?P<message>.+)\.
Member

SanketDG commented Aug 12, 2017

@yash-nisar it should be '(?P<message>.+)\.
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 12, 2017

Member

Oh, missed that. Will fix it 👍 @Makman2 review possible ?
Member

yash-nisar commented Aug 12, 2017

Oh, missed that. Will fix it 👍 @Makman2 review possible ?
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated bears/hypertext/HTMLHintBear.py
Show outdated Hide outdated tests/hypertext/htmlhint_test_files/test_bad_lowercase_tagname.html
tests/hypertext/htmlhint_test_files/.htmlhintrc
{
"inline-script-disabled": true,
"inline-style-disabled": true
}

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 13, 2017

Member

no newline on purpose?
Copy URL
@Makman2

Makman2 Aug 13, 2017

Member

no newline on purpose?

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 14, 2017

Member

I've faced this issue a lot of times. Should I open an issue for a NewlineBear or similar ?
Copy URL
@yash-nisar

yash-nisar Aug 14, 2017

Member

I've faced this issue a lot of times. Should I open an issue for a NewlineBear or similar ?

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 14, 2017

Member

SpaceConsistencyBear already supports this ;)
Copy URL
@Makman2

Makman2 Aug 14, 2017

Member

SpaceConsistencyBear already supports this ;)

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 14, 2017

Member

Maybe we should enable that feature on all the files ?
Copy URL
@yash-nisar

yash-nisar Aug 14, 2017

Member

Maybe we should enable that feature on all the files ?

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 14, 2017

Member

if you like ;) however sometimes test files shall contain such inconsistencies (not in your case though)
Copy URL
@Makman2

Makman2 Aug 14, 2017

Member

if you like ;) however sometimes test files shall contain such inconsistencies (not in your case though)
tests/hypertext/htmlhint_test_files/test_links_in_href.html
@@ -0,0 +1,3 @@
<!DOCTYPE html>
<a href="test.html">test1</a>
<a href="http://www.alibaba.com/">test1</a>

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 13, 2017

Member

also on purpose this missing newline?
Copy URL
@Makman2

Makman2 Aug 13, 2017

Member

also on purpose this missing newline?
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 14, 2017

Member

Updated @Makman2
Member

yash-nisar commented Aug 14, 2017

Updated @Makman2
Show outdated Hide outdated tests/hypertext/htmlhint_test_files/test_attribute_duplication.html
Show outdated Hide outdated tests/hypertext/htmlhint_test_files/test_bad_lowercase_attribute.html
@yash-nisar
bears/hypertext: Add HTMLHintBear 
Add `HTMLHintBear` that was worked upon by @AsnelChristian.
This PR is a continuation of @AsnelChristian's PR with some
modifications.

Closes #635
Loading status checks…
b49553a
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Aug 14, 2017

Member

Done @Makman2
Member

yash-nisar commented Aug 14, 2017

Done @Makman2
@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 14, 2017

Member

ack b49553a
Member

Makman2 commented Aug 14, 2017

ack b49553a

@Makman2 Makman2 added process/approved and removed process/pending review labels Aug 14, 2017

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Aug 14, 2017

Member

@rultor merge
Member

Makman2 commented Aug 14, 2017

@rultor merge
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Aug 14, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Aug 14, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b49553a into coala:master Aug 14, 2017
6 of 9 checks passed

6 of 9 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@yash-nisar yash-nisar deleted the yash-nisar:htmlhint branch Aug 14, 2017

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Aug 14, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

rultor commented Aug 14, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment