Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Remove unnecessary if UNSUPPORTED #2646

Merged
merged 2 commits into from Jul 29, 2018

Conversation

3 participants
@jayvdb
Copy link
Member

commented Jul 26, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb jayvdb force-pushed the jayvdb:travis-rm-used-unsupported branch from 5a6c607 to 11a79dc Jul 26, 2018

@gitmate-bot gitmate-bot added size/XS and removed size/S labels Jul 26, 2018

@jayvdb jayvdb force-pushed the jayvdb:travis-rm-used-unsupported branch from 11a79dc to 115c3b3 Jul 29, 2018

jayvdb added some commits Jul 26, 2018

.travis.yml: Remove unnecessary if UNSUPPORTED
The unsupported jobs have a separate script.
@MacBox7
Copy link
Contributor

left a comment

tests.sh also lacks hashbang. I don't see env_variables.sh being used in travis. But just a note that it also lacks the changes. Oh. It is used by tests.sh.

@jayvdb

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2018

tests.sh uses env_variables.sh

Those two files are due to be replaced ; see #2650

@jayvdb

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2018

@gitmate-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2018

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit 115c3b3 into coala:master Jul 29, 2018

6 of 10 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
review/gitmate/manual This commit needs review.
Details
review/gitmate/manual/pr This PR needs review.
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
review/gitmate/commit This commit has no issues. :)
Details
review/gitmate/pr This PR has no issues. :)
Details
@gitmate-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2018

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.