Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using user wide .coarc with a `files= **/*.x` glob leads to scanning complete home directory #4289

Open
dunkelstern opened this issue May 29, 2017 · 0 comments

Comments

@dunkelstern
Copy link

commented May 29, 2017

Steps to Reproduce

  1. Create a .coarc file in your home directory like this:
[javascript]
bears = ESLintBear
files = **/*.js
ignore = node_modules/, .eslintrc.js
  1. Change to your project directory cd ~/Projects/js-project
  2. Run coala without any command line arguments

Actual Results

[WARNING][18:00:22] The default coafile '.coafile' was not found. You can generate a configuration file with your current options by adding the `--save` flag or suppress any use of config files with `-I`.
Executing section javascript...

And then it hangs. Now I loaded it in the python debugger:

$ python -m pdb ~/.virtualenvs/coala/bin/coala
> /Users/johannes/.virtualenvs/coala/bin/coala(4)<module>()
-> import re
(Pdb) c
[WARNING][18:01:41] The default coafile '.coafile' was not found. You can generate a configuration file with your current options by adding the `--save` flag or suppress any use of config files with `-I`.
Executing section javascript...
^C
Program interrupted. (Use 'cont' to resume).
> /Users/johannes/Python/coala/lib/python3.6/site-packages/coala_utils/decorators.py(26)yield_once_generator()
-> yielded.append(item)
(Pdb) p yielded
...

The last print statement then lists all files contained in my home directory.

Expected Results

It checks all files contained in the current directory and below instead of using the glob relatively to the global .coarc file.

Reproducibility

Everytime there is no .coafile but only a .coarc with defined file globs

Additional Information:

Using OSX 10.12.x, Python 3.6.1 from Homebrew.

Pip listing of virtualenv:

alabaster (0.7.10)
ansicolor (0.2.4)
appdirs (1.4.3)
astroid (1.5.2)
autoflake (0.6.6)
autopep8 (1.3.2)
Babel (2.4.0)
bandit (1.4.0)
certifi (2017.4.17)
chardet (2.3.0)
click (6.6)
cmakelint (1.3.4.1)
coala (0.11.0)
coala-bears (0.11.0)
coala-utils (0.6.2)
colorama (0.3.9)
colorlog (2.10.0)
cppclean (0.12)
cpplint (1.3.0)
decorator (4.0.11)
dennis (0.9)
dependency-management (0.4.0)
docopt (0.6.2)
docutils (0.13.1)
eradicate (0.1.6)
future (0.16.0)
gitdb2 (2.0.2)
GitPython (2.1.3)
guess-language-spirit (0.5.3)
html-linter (0.3.0)
idna (2.5)
imagesize (0.7.1)
ipython-genutils (0.2.0)
isort (4.2.5)
Jinja2 (2.9.6)
jsonschema (2.6.0)
jupyter-core (4.3.0)
lazy-object-proxy (1.3.1)
libclang-py3 (3.4.0)
mando (0.3.3)
MarkupSafe (1.0)
mccabe (0.6.1)
munkres3 (1.0.5.5)
mypy-lang (0.4.6)
nbformat (4.3.0)
nltk (3.2.4)
packaging (16.8)
pbr (3.0.1)
pip (9.0.1)
polib (1.0.8)
proselint (0.7.0)
pycodestyle (2.3.1)
pydocstyle (1.1.1)
pyflakes (1.4.0)
Pygments (2.2.0)
pylint (1.7.1)
pyparsing (2.2.0)
PyPrint (0.2.6)
pyroma (2.2)
python-gnupg (0.4.0)
pytz (2017.2)
PyYAML (3.12)
radon (1.4.0)
requests (2.14.2)
restructuredtext-lint (1.0.1)
rstcheck (2.2)
safety (0.5.1)
sarge (0.1.4)
scspell3k (2.1)
setuptools (28.8.0)
six (1.10.0)
smmap2 (2.0.2)
snowballstemmer (1.2.1)
Sphinx (1.4.9)
stevedore (1.21.0)
template-remover (0.1.9)
termcolor (1.1.0)
traitlets (4.3.2)
typing (3.6.1)
unidiff (0.5.4)
urllib3 (1.21.1)
vim-vint (0.3.11)
vulture (0.10)
wrapt (1.10.10)
yamllint (1.6.1)
yapf (0.14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.