Skip to content

execute_bear: Improve AssertionError message generation #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yash-nisar opened this issue Jun 27, 2017 · 0 comments
Closed

execute_bear: Improve AssertionError message generation #4418

yash-nisar opened this issue Jun 27, 2017 · 0 comments
Assignees
@yash-nisar
Labels
area/tests

Comments

@yash-nisar
Copy link
Member

Instead of raise

AssertionError(str(err) + ' \n' + '\n'.join(msg))

use

raise AssertionError(str(err) + ''.join('\n' + m for m in msg))

so if msg is maybe really empty, we don't have a superfluous \n

type/test
area/tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-nisar yash-nisar

Labels
area/tests
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yash-nisar @gitmate-bot