New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected keyword argument in `new_process_output(...)` #4576

Closed
yash-nisar opened this Issue Jul 28, 2017 · 1 comment

Comments

3 participants
@yash-nisar
Member

yash-nisar commented Jul 28, 2017

By @jayvdb:
new_process_output() got an unexpected keyword argument 'cc_threshold'

https://travis-ci.org/coala/docker-coala-base/builds/256537062

This may have been a hidden error, exposed by recent improvement to coala core testing, or maybe something more sinister.

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jul 28, 2017

Member

This occurs because kwargs passed to process_output(...) have not been taken care of.

Member

yash-nisar commented Jul 28, 2017

This occurs because kwargs passed to process_output(...) have not been taken care of.

@Makman2 Makman2 added the type/bug label Jul 28, 2017

yash-nisar added a commit to yash-nisar/coala that referenced this issue Jul 29, 2017

LocalBearTestHelper: Add **process_output_kwargs
Add `**process_output_kwargs` argument to `new_process_output(...)`
and `old_process_output(...)` because the keyword arguments were
not taken care of in bbb99f9.

Fixes coala#4576
Related to coala/docker-coala-base#219

@rultor rultor closed this in #4579 Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment