/coala

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Embed asciinema #2080

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees

@SanketDG SanketDG

Labels
Milestone
No milestone
5 participants
@SanketDG @AbdealiJK @sickill @sils @gitmate-bot
@SanketDG
Member

SanketDG commented Apr 26, 2016

Fixes #2052

@gitmate-bot gitmate-bot added process/pending review size/XS labels Apr 26, 2016

@AbdealiJK

This comment has been minimized.

Show comment
Hide comment
@AbdealiJK

AbdealiJK Apr 26, 2016

Contributor

I can;t see it in the README preview from github
Contributor

AbdealiJK commented Apr 26, 2016

I can;t see it in the README preview from github

SanketDG added some commits Apr 26, 2016

@SanketDG
README: Set asciinema width to 600px 
Fixes #2052
Loading status checks…
e478eb5
@SanketDG
FIX
Loading status checks…
4c6f5b5

@gitmate-bot gitmate-bot added size/S and removed size/XS labels Apr 26, 2016

@SanketDG

This comment has been minimized.

Show comment
Hide comment
@SanketDG

SanketDG Apr 26, 2016

Member

Tried two things:

  • Use ..raw html
  • Set :width:

Both didn't work.
Member

SanketDG commented Apr 26, 2016

Tried two things:

  • Use ..raw html
  • Set :width:

Both didn't work.

@sils sils added process/wip and removed process/pending review labels Apr 26, 2016

@sickill

This comment has been minimized.

Show comment
Hide comment
@sickill

sickill Apr 26, 2016

The browser is showing the image in full width (because it doesn't have width specified), expanding the container. It's enough to set width="100%" on the img tag to fix this.

sickill commented Apr 26, 2016

The browser is showing the image in full width (because it doesn't have width specified), expanding the container. It's enough to set width="100%" on the img tag to fix this.

@sils sils assigned SanketDG Apr 26, 2016

@sils

This comment has been minimized.

Show comment
Hide comment
@sils

sils Apr 26, 2016

Member

@sickill thanks for the hint! We'll look into it.
Member

sils commented Apr 26, 2016

@sickill thanks for the hint! We'll look into it.
@AbdealiJK

This comment has been minimized.

Show comment
Hide comment
@AbdealiJK

AbdealiJK Apr 27, 2016

Contributor

Closing this and trying it out myself
Contributor

AbdealiJK commented Apr 27, 2016

Closing this and trying it out myself

@AbdealiJK AbdealiJK closed this Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment