New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalBearTestHelper: Add ``assertObjectsEqual`` #4310

Merged
merged 1 commit into from Feb 21, 2018

Conversation

@yash-nisar
Member

yash-nisar commented Jun 2, 2017

Add assertObjectsEqual(..) method that compares individual
fields of the Result object and yields better, easy to understand
messages in case of an attribute mismatch.

Closes #4302

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 2, 2017

Member

status/blocked on coala_utils release which will include https://gitlab.com/coala/coala-utils/merge_requests/42

Member

yash-nisar commented Jun 2, 2017

status/blocked on coala_utils release which will include https://gitlab.com/coala/coala-utils/merge_requests/42

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 2, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 2, 2017

Member

Note that the tests will fail because we still don't have the __compare_fields attribute which will only be added after https://gitlab.com/coala/coala-utils/merge_requests/42 is merged and a new version of coala_utils is released(maybe).

Member

yash-nisar commented Jun 2, 2017

Note that the tests will fail because we still don't have the __compare_fields attribute which will only be added after https://gitlab.com/coala/coala-utils/merge_requests/42 is merged and a new version of coala_utils is released(maybe).

Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Jun 11, 2017

Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Collaborator

gitmate-bot commented Jun 11, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 13, 2017

Member

Will fix things suggested by the review comments in the next iteration and iterate over the list containing more than multiple results.

Member

yash-nisar commented Jun 13, 2017

Will fix things suggested by the review comments in the next iteration and iterate over the list containing more than multiple results.

@yash-nisar yash-nisar changed the title from LocalBearTestHelper: Add ``assertObjectsEqual`` to WIP LocalBearTestHelper: Add ``assertObjectsEqual`` Jun 19, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 19, 2017

Updated @Makman2

Show outdated Hide outdated coalib/results/Result.py

@gitmate-bot gitmate-bot added size/S size/M and removed size/M size/S labels Jun 21, 2017

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 22, 2017

Member

How does this look ? @Makman2

Member

yash-nisar commented Jun 22, 2017

How does this look ? @Makman2

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 22, 2017

Member

Strange circle only error. The package seems to be installed but cannot be imported. However, the tests pass for travis and appveyor.

Member

yash-nisar commented Jun 22, 2017

Strange circle only error. The package seems to be installed but cannot be imported. However, the tests pass for travis and appveyor.

Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
Show outdated Hide outdated coalib/testing/LocalBearTestHelper.py
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Feb 2, 2018

Member

@Makman2 Ready for merge ?

Member

yash-nisar commented Feb 2, 2018

@Makman2 Ready for merge ?

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Feb 2, 2018

Collaborator

Sorry @yash-nisar, you do not have the necessary permission levels to perform the action.

Collaborator

gitmate-bot commented Feb 2, 2018

Sorry @yash-nisar, you do not have the necessary permission levels to perform the action.

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Feb 14, 2018

ack 14642d8

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Feb 21, 2018

@gitmate-bot rebase

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Feb 21, 2018

Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Collaborator

gitmate-bot commented Feb 21, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

LocalBearTestHelper: Add ``assertObjectsEqual``
Add ``assertObjectsEqual(..)`` method that compares individual
fields of the Result object and yields better, easy to understand
messages in case of an attribute mismatch.

Closes #4302
@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Feb 21, 2018

Collaborator

Automated rebase with GitMate.io was successful! 🎉

Collaborator

gitmate-bot commented Feb 21, 2018

Automated rebase with GitMate.io was successful! 🎉

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2
Member

Makman2 commented Feb 21, 2018

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Feb 21, 2018

Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

Collaborator

gitmate-bot commented Feb 21, 2018

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Feb 21, 2018

Collaborator

Automated fastforward with GitMate.io was successful! 🎉

Collaborator

gitmate-bot commented Feb 21, 2018

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 31ad864 into coala:master Feb 21, 2018

8 of 10 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit This commit has no issues. :)
Details
review/gitmate/manual This commit was acknowledged. :)
Details
review/gitmate/manual/pr This PR is reviewed. :)
Details
review/gitmate/pr This PR has no issues. :)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment