New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AspectList: Add ``get()`` method #4392

Merged
merged 3 commits into from Jun 26, 2017

Conversation

@adhikasp
Member

adhikasp commented Jun 23, 2017

Show outdated Hide outdated tests/bearlib/aspects/InstanceTest.py
Show outdated Hide outdated tests/bearlib/aspects/InstanceTest.py
Show outdated Hide outdated tests/bearlib/aspects/InstanceTest.py
Show outdated Hide outdated tests/bearlib/aspects/InstanceTest.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py

@adhikasp adhikasp changed the title from aspectlist: Add ``get()`` method to AspectList: Add ``get()`` method Jun 25, 2017

@gitmate-bot gitmate-bot added size/L size/XL and removed size/L labels Jun 26, 2017

Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/collections.py
@SubAspect.subaspect
class SubSubAspect:
"""
Definition

This comment has been minimized.

@jayvdb

jayvdb Jun 26, 2017

Member

trailing period?
(or are they omitted for aspect/taste docstrings?)

@jayvdb

jayvdb Jun 26, 2017

Member

trailing period?
(or are they omitted for aspect/taste docstrings?)

This comment has been minimized.

@adhikasp

adhikasp Jun 26, 2017

Member

Omitted, like SubAspect declaration above it

@adhikasp

adhikasp Jun 26, 2017

Member

Omitted, like SubAspect declaration above it

@jayvdb

jayvdb approved these changes Jun 26, 2017

@userzimmermann

userzimmermann requested changes Jun 26, 2017 edited

Great work @adhikasp! 🎉 But there are still lots of things to simplify and cleanup

cc @coala/aspects-developers @jayvdb

Show outdated Hide outdated coalib/bearlib/aspects/collections.py
Show outdated Hide outdated coalib/bearlib/aspects/collections.py
Show outdated Hide outdated tests/bearlib/aspects/InstanceTest.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
Show outdated Hide outdated coalib/bearlib/aspects/base.py
@userzimmermann

And please change commit message of b236df2 to the actual things done there

@userzimmermann

@adhikasp So instead of https://github.com/coala/coala/pull/4392/files#r123961178 let's at least finally address this ;)

cc @jayvdb

Show outdated Hide outdated coalib/bearlib/aspects/base.py
@gitmate-bot

This comment has been minimized.

Show comment
Hide comment
@gitmate-bot

gitmate-bot Jun 26, 2017

Collaborator

Comment on c67ba7aaa6f43fcab20c2f21b3a8a26ae982868d.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

GitCommitBear, severity NORMAL, section commit.

Collaborator

gitmate-bot commented Jun 26, 2017

Comment on c67ba7aaa6f43fcab20c2f21b3a8a26ae982868d.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

GitCommitBear, severity NORMAL, section commit.

adhikasp added some commits Jun 26, 2017

aspectbase: Add ``get()`` method
``get()`` method serve as quick way to get a specific, deep subaspects
of an aspect. This also pave the path to implement ``get()`` method in
aspectlist class. The ``get()`` method was implemented by special
descriptor class so it could be accessed from aspectclass AND 
aspectclass instance.

Relates to #4384
Closes #4410
AspectList: Add ``get()`` method
Usable for bears API

Closes #4384
@userzimmermann

This comment has been minimized.

Show comment
Hide comment
@userzimmermann
Member

userzimmermann commented Jun 26, 2017

@userzimmermann

This comment has been minimized.

Show comment
Hide comment
@userzimmermann
Member

userzimmermann commented Jun 26, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 26, 2017

Contributor

@rultor merge

@userzimmermann OK, I'll try to merge now. You can check the progress of the merge here

Contributor

rultor commented Jun 26, 2017

@rultor merge

@userzimmermann OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 705d256 into coala:master Jun 26, 2017

6 of 9 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 26, 2017

Contributor

@rultor merge

@userzimmermann Done! FYI, the full log is here (took me 2min)

Contributor

rultor commented Jun 26, 2017

@rultor merge

@userzimmermann Done! FYI, the full log is here (took me 2min)

@adhikasp adhikasp deleted the adhikasp:adhikasp/get branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment