New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute_bear: Improve ``AssertionError`` message #4417

Merged
merged 1 commit into from Jun 30, 2017

Conversation

7 participants
@yash-nisar
Member

yash-nisar commented Jun 27, 2017

Improve AssertionError message so if msg is maybe really empty,
we don't have a superfluous \n.

Closes coala/coala-bears#1870

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jun 27, 2017

@Monal5031

This comment has been minimized.

Show comment
Hide comment
@Monal5031

Monal5031 Jun 27, 2017

Member

ack 99d1a88

Member

Monal5031 commented Jun 27, 2017

ack 99d1a88

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 28, 2017

Member

@Makman2 Rebased 👍

Member

yash-nisar commented Jun 28, 2017

@Makman2 Rebased 👍

@JohnMoutafis

JohnMoutafis approved these changes Jun 29, 2017 edited

@JohnMoutafis

This comment has been minimized.

Show comment
Hide comment
@JohnMoutafis

JohnMoutafis Jun 29, 2017

Member

reack 3d5f9cc

Member

JohnMoutafis commented Jun 29, 2017

reack 3d5f9cc

@Makman2

This comment has been minimized.

Show comment
Hide comment
@Makman2

Makman2 Jun 30, 2017

Member

@yash-nisar sorry I was too late ;) you may ask on the coala channel to merge your PR if I'm not there 👍

Member

Makman2 commented Jun 30, 2017

@yash-nisar sorry I was too late ;) you may ask on the coala channel to merge your PR if I'm not there 👍

execute_bear: Improve ``AssertionError`` message
Improve AssertionError message so if ``msg`` is maybe really empty,
we don't have a superfluous ``\n``.

Closes #4418
@sils

This comment has been minimized.

Show comment
Hide comment
@sils

sils Jun 30, 2017

Member

reack 0edf040

Member

sils commented Jun 30, 2017

reack 0edf040

@sils

This comment has been minimized.

Show comment
Hide comment
@sils

sils Jun 30, 2017

Member

@rultor merge

Member

sils commented Jun 30, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 30, 2017

Contributor

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

Contributor

rultor commented Jun 30, 2017

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0edf040 into coala:master Jun 30, 2017

6 of 8 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 30, 2017

Contributor

@rultor merge

@sils Done! FYI, the full log is here (took me 2min)

Contributor

rultor commented Jun 30, 2017

@rultor merge

@sils Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:improve-message branch Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment