New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalBearTestHelper: Add **process_output_kwargs #4579

Merged
merged 1 commit into from Jul 29, 2017

Conversation

4 participants
@yash-nisar
Member

yash-nisar commented Jul 29, 2017

Add **process_output_kwargs argument to new_process_output(...)
and old_process_output(...) because the keyword arguments were
not taken care of in bbb99f9.

Fixes #4576
Related to coala/docker-coala-base#219

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

LocalBearTestHelper: Add **process_output_kwargs
Add `**process_output_kwargs` argument to `new_process_output(...)`
and `old_process_output(...)` because the keyword arguments were
not taken care of in bbb99f9.

Fixes #4576
Related to coala/docker-coala-base#219
@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar
Member

yash-nisar commented Jul 29, 2017

@jayvdb

jayvdb approved these changes Jul 29, 2017

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb
Member

jayvdb commented Jul 29, 2017

ack 2868324

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Jul 29, 2017

Member

@rultor merge

Member

jayvdb commented Jul 29, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 29, 2017

Contributor

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

Contributor

rultor commented Jul 29, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2868324 into coala:master Jul 29, 2017

6 of 9 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit This commit has no issues. :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr This PR has no issues. :)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jul 29, 2017

Contributor

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

Contributor

rultor commented Jul 29, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:jscomplexity branch Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment