Aspects: Add more robust setting checks #4582

adhikasp · 2017-07-29T10:47:05Z

jayvdb · 2017-08-16T18:01:33Z

coalib/settings/Setting.py

+    """
+    try:
+        return Language[name]
+    except AttributeError:


This line of your patch is correct, but will need to change if #4643 is merged, as that fixes a fairly fundamental exception problem.

jayvdb · 2017-08-16T18:09:33Z

coalib/settings/Setting.py

@@ -44,6 +45,21 @@ def glob_list(obj, *args, **kwargs):
    return obj.__glob_list__(*args, **kwargs)


+def language_obj(name):


I'm not keen on this name. This name needs to be used in Bear.run() override arg lists, and becomes part of our documentation. Can it simply be language ? And be used as def run(.... , language: language): ; while that looks like it might be wrong, it should work and do the right thing.

The other alternative is that the run argument validator should work correctly with def run(.... , language: Language): , which would require improvements to the argument validator so that dict subclass, like Language, are checked using the value to key-index the dict, and thus KeyError would be the expected exception of incorrect values instead of ValueError.

Also, in order to properly solve #4463 , this PR should include a test which is a Bear using language: language.

jayvdb

Very minor improvements needed

jayvdb · 2017-08-22T16:02:54Z

coalib/settings/ConfigurationGathering.py

+        return False
+
+    if not len(aspects_language):
+        logging.warning('Language setting is not found in section `{}`. '


Language setting .. -> Setting 'language' ..

jayvdb · 2017-08-22T16:05:22Z

tests/settings/ConfigurationGatheringTest.py

+                logging.getLogger()) as cm:
+            self.assertTrue(check_aspect_config(
+                            self.section, acquire_settings))
+            self.assertRegex(cm.output[0], 'Language setting is not found in '


start the string on a new line. (also below..)

jayvdb · 2017-08-22T16:06:21Z

tests/settings/SettingTest.py

 from coalib.settings.Setting import (
    Setting, path, path_list, url, typed_dict, typed_list, typed_ordered_dict,
-    glob, glob_list)
+    glob, glob_list, language)


on a new line, as it isnt a glob.

jayvdb · 2017-08-24T16:47:44Z

coalib/settings/ConfigurationGathering.py

    return sections


+def check_aspect_config(section, acquire_settings):


this isnt a check_.. , as it does UI and it modifies the section

adhikasp · 2017-08-27T08:04:35Z

Add new commit to fix #4681

jayvdb · 2017-08-27T10:42:04Z

coalib/settings/ConfigurationGathering.py

+    return True
+
+
+def validate_and_inject_language(sections):


This can be just _set_section_language . validation is assumed. doesnt need to be part of public API

jayvdb · 2017-08-27T10:42:43Z

coalib/settings/Section.py

@@ -46,24 +46,18 @@ def append_to_sections(sections,

 def extract_aspects_from_section(section):
    """
-    Extracts aspects and their related settings from a section and create an
-    AspectList from it.
+    Extracts aspects settings from a section into an AspectList.


Singular 'Extract', not plural

jayvdb · 2017-08-27T11:11:41Z

ack 67ef72b 5f90a8b 25893e2 c8f1405 fc75951 82ec615 9979e16

``aspect`` passed to ``Result`` should be instance of aspectbase.

Move everything related to validating a correct aspect section into its own function.

Closes coala#4463

Dynamically create `aspects` attribute only when aspects is detected is prone to many edge case bugs. Fixes coala#4681

jayvdb · 2017-08-27T11:19:04Z

reack 256854c c7135e9 1bd2e87 5476acb 11f564d 141f44f a697b09

jayvdb · 2017-08-27T12:16:20Z

@rultor merge

rultor · 2017-08-27T12:17:38Z

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2017-08-27T12:19:24Z

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

gitmate-bot added process/pending review size/S labels Jul 29, 2017

userzimmermann assigned adhikasp Aug 2, 2017

userzimmermann added the area/aspects label Aug 2, 2017

userzimmermann added this to the #aspectsYEAH milestone Aug 2, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from 1988cc9 to 42cfd09 Compare August 4, 2017 13:59

jayvdb reviewed Aug 16, 2017

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 16, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from 42cfd09 to 24dc08b Compare August 22, 2017 10:20

gitmate-bot added process/pending review size/M area/config area/languages difficulty/low and removed process/wip size/S labels Aug 22, 2017

jayvdb requested changes Aug 22, 2017

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 22, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from 24dc08b to 3e53e03 Compare August 23, 2017 05:36

gitmate-bot added process/pending review and removed process/wip labels Aug 23, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from 3e53e03 to a0adcba Compare August 23, 2017 10:33

jayvdb added process/approved The PR is approved and will be merged soon and removed process/pending review labels Aug 23, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from a0adcba to 2179535 Compare August 24, 2017 07:32

gitmate-bot added the process/pending review label Aug 24, 2017

jayvdb reviewed Aug 24, 2017

View reviewed changes

adhikasp force-pushed the adhikasp/aspect-check branch 2 times, most recently from 4e6e597 to e4455e0 Compare August 27, 2017 08:04

jayvdb requested changes Aug 27, 2017

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 27, 2017

adhikasp force-pushed the adhikasp/aspect-check branch from e4455e0 to 67ef72b Compare August 27, 2017 10:52

gitmate-bot added process/pending review and removed process/wip labels Aug 27, 2017

jayvdb approved these changes Aug 27, 2017

View reviewed changes

jayvdb added process/wip process/approved The PR is approved and will be merged soon and removed process/pending review process/wip labels Aug 27, 2017

adhikasp added 7 commits August 27, 2017 18:15

AspectTestBear: Fix return result

256854c

``aspect`` passed to ``Result`` should be instance of aspectbase.

BearTest: Make check_message could check regex

c7135e9

coalaTest: Add running with aspect test

1bd2e87

Setting: Create language type hint

5476acb

ConfigurationGathering: Refactor aspect validation

11f564d

Move everything related to validating a correct aspect section into its own function.

Validate and cache language setting into Section

141f44f

Closes coala#4463

Section: Add aspects attribute

a697b09

Dynamically create `aspects` attribute only when aspects is detected is prone to many edge case bugs. Fixes coala#4681

adhikasp force-pushed the adhikasp/aspect-check branch from 67ef72b to a697b09 Compare August 27, 2017 11:16

gitmate-bot added the process/pending review label Aug 27, 2017

rultor merged commit a697b09 into coala:master Aug 27, 2017

adhikasp deleted the adhikasp/aspect-check branch August 27, 2017 12:26

Aspects: Add more robust setting checks #4582

Aspects: Add more robust setting checks #4582

adhikasp commented Jul 29, 2017

jayvdb Aug 16, 2017

jayvdb Aug 16, 2017

jayvdb left a comment

jayvdb Aug 22, 2017

jayvdb Aug 22, 2017

jayvdb Aug 22, 2017

jayvdb Aug 24, 2017

adhikasp commented Aug 27, 2017

jayvdb Aug 27, 2017

jayvdb Aug 27, 2017

jayvdb commented Aug 27, 2017

jayvdb commented Aug 27, 2017

jayvdb commented Aug 27, 2017

rultor commented Aug 27, 2017

rultor commented Aug 27, 2017

		@@ -44,6 +45,21 @@ def glob_list(obj, args, *kwargs):
		return obj.__glob_list__(args, *kwargs)


		def language_obj(name):

		return sections


		def check_aspect_config(section, acquire_settings):

Aspects: Add more robust setting checks #4582

Aspects: Add more robust setting checks #4582

Conversation

adhikasp commented Jul 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adhikasp commented Aug 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Aug 27, 2017

jayvdb commented Aug 27, 2017

jayvdb commented Aug 27, 2017

rultor commented Aug 27, 2017

rultor commented Aug 27, 2017