Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore triple quote string literals. #4632

Merged
merged 2 commits into from Aug 13, 2017
Merged

Conversation

damngamerz
Copy link
Member

@damngamerz damngamerz commented Aug 9, 2017

Ignore whole triple quote string literal DocComment.

Fixes #4631

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

yield doc
# Ignore string literals
ignore_regex = re.compile(
'^\s*(?P<marker>' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you allow r here? Sometimes its possible that the docstring is raw

Commit needs to be reverted as this created a bug where
end marker of string literals were considered to be the
starting of new docstrings.
This reverts commit 0114024.
@SanketDG
Copy link
Member

ack 893c858 1c4e43f

@SanketDG
Copy link
Member

unack 1c4e43f

Ignore whole triple quoted string literal
DocComment.

Fixes coala#4631
@SanketDG
Copy link
Member

ack cebe4f2

@SanketDG
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 13, 2017

@rultor merge

@SanketDG OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cebe4f2 into coala:master Aug 13, 2017
@rultor
Copy link
Contributor

rultor commented Aug 13, 2017

@rultor merge

@SanketDG Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Bug DocumentationAPI string literals.
4 participants