Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectors: Warn unfulfilled aspects #4657

Merged
merged 1 commit into from Aug 23, 2017

Conversation

@adhikasp
Copy link
Member

@adhikasp adhikasp commented Aug 23, 2017

Show warning if some of requested aspects could not be fulfilled
by coala.

Closes #4656

index = kinds.index(_get_kind(bear))
# Avoid duplicate
if bear not in bears_found[index]:
bears_found[index].append(bear)
break
if not found:
unfulfilled_aspects.append(type(aspect).__qualname__)
Copy link
Member

@jayvdb jayvdb Aug 23, 2017

Use for..else

Copy link
Member Author

@adhikasp adhikasp Aug 23, 2017

Wow, I just learn about this!

"'Root\.Redundancy\.UnusedVariable\.UnusedParameter'"
'\]')

self.assertEqual(len(global_bears), 0)
Copy link
Member

@jayvdb jayvdb Aug 23, 2017

AssertEqual to empty list. Avoid len below also.

@@ -288,6 +292,25 @@ def test_aspect_bear(self):
self.assertEqual(len(local_bears), 1)
self.assertIs(local_bears[0].name, 'AspectTestBear')

def test_collect_bears_by_aspects_unfulfilled_aspect(self):
Copy link
Member

@jayvdb jayvdb Aug 23, 2017

'By-apects' is redundant

Show warning if some of requested aspects could not be fulfilled
by coala.

Closes coala#4656
@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 23, 2017

ack 5001406

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Aug 23, 2017

@rultor merge

@rultor
Copy link
Contributor

@rultor rultor commented Aug 23, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5001406 into coala:master Aug 23, 2017
6 of 8 checks passed
6 of 8 checks passed
ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
@codecov[bot]
codecov/project 100% (target 100%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit This commit has no issues. :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr This PR has no issues. :)
Details
@rultor
Copy link
Contributor

@rultor rultor commented Aug 23, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@adhikasp adhikasp deleted the adhikasp/unfulfilled-aspect branch Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants