Test: Add test FilterHelperTest for bear filters #4984
Conversation
tests/parsing/FilterHelperTest.py
Outdated
| TEST_BEARS_COUNT, | ||
| ) | ||
|
|
||
| class FilterHelperTest(unittest.TestCase): |
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
Origin: PycodestyleBear (E302), Section: autopep8.
This add FilterHelperTest.py as companion to FilterTest.py to test InvalidFilterException. Closes coala#4864
pradeepgangwar
force-pushed
the
issue-4864
branch
from
79ddf3d
to
ba7dc87
Compare
|
Please run your PR at your local machine before push. All the issues reviewed by @gitmate-bot can be automatically solved by running |
|
@ujjaldas1997 Glimate reviews are already fixed and PR is ready for review. Have a look at the tests. :) |
|
Only one issue is there though |
|
There are no such warnings from gitmate now. I already fixed it. |
| retval, stdout, stderr = execute_coala( | ||
| coala.main, 'coala', '-B', '--filter-by', 'some_filter', | ||
| 'abc') | ||
| self.assertRaises(InvalidFilterException) |
There was a problem hiding this comment.
that's not how this function works ;)
Anyway:
The issues states not to execute coala as it's too high-level for a unit-test. Please directly invoke FilterHelper methods.
|
@pradeepgangwar why closing? ;) |
|
@Makman2 I need some time, actually i got busy with my daily schedule these days. I will update here if there is any progress. |
|
Please tell us earlier and don't close PRs :D However, if you're too long away we are going to reassign the issue ;) |
|
Incomplete and issue was reassigned and is now looking good at #5313 |
This add FilterHelperTest.py as companion to FilterTest.py to test
InvalidFilterException.
Closes #4864
Checklist
them.