Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Change colorlog>=2.7,<5.0 #5981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

realJema
Copy link

@realJema realJema commented Feb 9, 2019

Adds support for Versions 4.*

Closes #5975

@gitmate-bot
Copy link
Collaborator

Comment on 7a8a066.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

Copy link
Member

@shashank-b shashank-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @realJema
You would have to modify the commit message as per the commit guidelines
Please make all the changes in this PR and not in a new one.

@realJema realJema changed the title fix issue #5975 requirements.txt: Change colorlog>=2.7,<5.0 Feb 9, 2019
@jayvdb
Copy link
Member

jayvdb commented Feb 9, 2019

You need to use git to fix it.

Copy link

@frextrite frextrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the guidelines of writing a good commit message. The shortlog must be of 50 characters or less, and the commit must contain a body and the reference to the issue it closes.

Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you have to amend the "commit message" , not the title :)

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

@realJema
Copy link
Author

I updated the commit message, I hope its ok now.

@gitmate-bot
Copy link
Collaborator

Comment on 7a8a066.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 7a8a066.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 989504e.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 989504e.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

Copy link
Member

@shashank-b shashank-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @realJema
You need to squash the commits into one and the commit header and body still needs to be modified. Also, please do it in this PR and don't open a new one. Going through the commit guidelines and newcomers' guide might help you (links in the comments above).

@gitmate-bot
Copy link
Collaborator

Comment on d12f8f3.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on b51ddd4.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on b51ddd4.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 7a8a066.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on ef94c8d.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

@KVGarg
Copy link
Contributor

KVGarg commented Feb 12, 2019

Hi @realJema Please follow commit guidelines. Also, you need to squash your commits. Also, correctly rebase you fork which is increasing your commits over a single issue.

@jayvdb
Copy link
Member

jayvdb commented Feb 14, 2019

You must squash your commits. Ask for help on gitter. Otherwise you will be unassigned from this issue. Do not open a new PR - no exceptions.

@gitmate-bot
Copy link
Collaborator

Comment on 02ea4ae.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

1 similar comment
@gitmate-bot
Copy link
Collaborator

Comment on 02ea4ae.

Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 686a4ec.

Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50).

Origin: GitCommitBear, Section: commit.

@gitmate-bot
Copy link
Collaborator

Comment on 686a4ec.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)

Origin: GitCommitBear, Section: commit.

This commit adds the support for colorlog
versions 4.* in requirements.txt and moban.yaml

Closes coala#5975
Copy link
Member

@budukhyash budukhyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@AkshJain99 AkshJain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine but you need to make travis green please go through it
except that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

9 participants