New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements.txt: Change colorlog>=2.7,<5.0 #5981
base: master
Are you sure you want to change the base?
Conversation
Comment on 7a8a066. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @realJema
You would have to modify the commit message as per the commit guidelines
Please make all the changes in this PR and not in a new one.
You need to use git to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through the guidelines of writing a good commit message. The shortlog must be of 50 characters or less, and the commit must contain a body and the reference to the issue it closes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you have to amend
the "commit message" , not the title :)
Comment on ef94c8d. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on ef94c8d. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
I updated the commit message, I hope its ok now. |
Comment on 7a8a066. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
Comment on ef94c8d. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on ef94c8d. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
Comment on 7a8a066. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
Comment on 989504e. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on 989504e. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @realJema
You need to squash the commits into one and the commit header and body still needs to be modified. Also, please do it in this PR and don't open a new one. Going through the commit guidelines and newcomers' guide might help you (links in the comments above).
Comment on d12f8f3. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
Comment on b51ddd4. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on b51ddd4. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
Comment on 7a8a066. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
Comment on ef94c8d. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on ef94c8d. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
Hi @realJema Please follow commit guidelines. Also, you need to squash your commits. Also, correctly rebase you fork which is increasing your commits over a single issue. |
You must squash your commits. Ask for help on gitter. Otherwise you will be unassigned from this issue. Do not open a new PR - no exceptions. |
Comment on 02ea4ae. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
1 similar comment
Comment on 02ea4ae. Shortlog of the HEAD commit contains 81 character(s). This is 31 character(s) longer than the limit (81 > 50). Origin: GitCommitBear, Section: |
Comment on 686a4ec. Shortlog of the HEAD commit contains 58 character(s). This is 8 character(s) longer than the limit (58 > 50). Origin: GitCommitBear, Section: |
Comment on 686a4ec. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
This commit adds the support for colorlog versions 4.* in requirements.txt and moban.yaml Closes coala#5975
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are fine but you need to make travis green please go through it
except that LGTM
Adds support for Versions 4.*
Closes #5975