New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsoc: [please merge :P ] LabHub: Add github plugin with invite feature #71

Merged
merged 6 commits into from Jun 19, 2017

Conversation

9 participants
@meetmangukiya
Copy link
Member

meetmangukiya commented May 31, 2017

Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

Closes #2

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch 12 times, most recently from 8ecbfaa to 98b064c May 31, 2017

@meetmangukiya meetmangukiya added the ready label May 31, 2017

@meetmangukiya meetmangukiya changed the title github: Add github plugin with invite feature [do not merge]github: Add github plugin with invite feature May 31, 2017

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch from 98b064c to 011ad53 Jun 1, 2017

name = github

[Documentation]
description = GitHub utilities exposed through errbpt

This comment has been minimized.

@meetmangukiya

meetmangukiya Jun 1, 2017

Author Member

typo

@@ -0,0 +1,111 @@
import logging

This comment has been minimized.

@meetmangukiya

meetmangukiya Jun 1, 2017

Author Member

use internal logging object provided by errbot instead

else:
return "Nice try :poop:"

@re_botcmd(pattern=r"Hello\s*,?\s*world", flags=re.IGNORECASE)

This comment has been minimized.

@meetmangukiya

meetmangukiya Jun 1, 2017

Author Member

re is not imported

return "Nice try :poop:"

@re_botcmd(pattern=r"Hello\s*,?\s*world", flags=re.IGNORECASE)
def invite_hello_world(self, msg, match):

This comment has been minimized.

@meetmangukiya

meetmangukiya Jun 1, 2017

Author Member

this should go in next commit

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch from 011ad53 to c802ee8 Jun 1, 2017

version = 3

[Errbot]

This comment has been minimized.

@meetmangukiya

meetmangukiya Jun 1, 2017

Author Member

remove trailing line

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch 4 times, most recently from ed1fdb5 to 52f6cf3 Jun 1, 2017

@meetmangukiya meetmangukiya added process/wip and removed ready labels Jun 2, 2017

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch 6 times, most recently from 3cfef2e to bcb4d18 Jun 2, 2017

@Udayan12167

This comment has been minimized.

Copy link

Udayan12167 commented Jun 18, 2017

ack 8d1d3d2

meetmangukiya added some commits Jun 3, 2017

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch from 4eb50c6 to a7c8cb1 Jun 18, 2017

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 18, 2017

ack c83e767

@sils

This comment has been minimized.

Copy link
Member

sils commented Jun 18, 2017

ack c83e767

@hemangsk

This comment has been minimized.

Copy link
Member

hemangsk commented Jun 18, 2017

ack ce2a27a

@hemangsk

This comment has been minimized.

Copy link
Member

hemangsk commented Jun 18, 2017

ack c83e767

@jayvdb

jayvdb approved these changes Jun 19, 2017

@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

ack ce2a27a

1 similar comment
@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

ack ce2a27a

@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

ack c83e767

@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

4ae86a7 ack

@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

ack 5271c55

@arjunsinghy96

This comment has been minimized.

Copy link
Collaborator

arjunsinghy96 commented Jun 19, 2017

ack b4895f9

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 19, 2017

ack a7c8cb1

meetmangukiya added some commits Jun 12, 2017

@meetmangukiya meetmangukiya force-pushed the meet/plug/github branch from a7c8cb1 to e541c60 Jun 19, 2017

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 19, 2017

ack 68f4b85

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 19, 2017

ack 93b5b80

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 19, 2017

ack e541c60

@meetmangukiya

This comment has been minimized.

Copy link
Member Author

meetmangukiya commented Jun 19, 2017

@rultor merge

@rultor

This comment has been minimized.

Copy link

rultor commented Jun 19, 2017

@rultor merge

@meetmangukiya OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e541c60 into master Jun 19, 2017

7 checks passed

GitMate-2 PR Review This PR has no issues. :)
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 7764901
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
review/gitmate/manual This commit was acknowledged.
Details
semaphoreci The build passed on Semaphore.
Details
@rultor

This comment has been minimized.

Copy link

rultor commented Jun 19, 2017

@rultor merge

@meetmangukiya Done! FYI, the full log is here (took me 2min)

@meetmangukiya meetmangukiya deleted the meet/plug/github branch Dec 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment