New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker breakage #185

Merged
merged 3 commits into from Jun 18, 2017

Conversation

4 participants
@yash-nisar
Member

yash-nisar commented Jun 18, 2017

Closes #182 and #184

@yash-nisar

This comment has been minimized.

Show comment
Hide comment
@yash-nisar

yash-nisar Jun 18, 2017

Member

@jayvdb quick review ?

Member

yash-nisar commented Jun 18, 2017

@jayvdb quick review ?

@gitmate-bot gitmate-bot added size/M size/S and removed size/S size/M labels Jun 18, 2017

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb
Member

jayvdb commented Jun 18, 2017

@jayvdb

This comment has been minimized.

Show comment
Hide comment
@jayvdb

jayvdb Jun 18, 2017

Member

@rultor merge

Member

jayvdb commented Jun 18, 2017

@rultor merge

@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 18, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented Jun 18, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 51fb17d into coala:master Jun 18, 2017

4 of 5 checks passed

ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor

This comment has been minimized.

Show comment
Hide comment
@rultor

rultor Jun 18, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

rultor commented Jun 18, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:breakage-fix branch Jun 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment