Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker breakage #185

Merged
merged 3 commits into from Jun 18, 2017
Merged

Fix docker breakage #185

merged 3 commits into from Jun 18, 2017

Conversation

@yash-nisar
Copy link
Member

yash-nisar commented Jun 18, 2017

Closes #182 and #184

@yash-nisar yash-nisar force-pushed the yash-nisar:breakage-fix branch from 3fc6159 to e6b2804 Jun 18, 2017
@yash-nisar
Copy link
Member Author

yash-nisar commented Jun 18, 2017

@jayvdb quick review ?

@gitmate-bot gitmate-bot added size/M and removed size/S labels Jun 18, 2017
@yash-nisar yash-nisar force-pushed the yash-nisar:breakage-fix branch from cb51706 to e6b2804 Jun 18, 2017
@gitmate-bot gitmate-bot added size/S and removed size/M labels Jun 18, 2017
Fixes #182
@yash-nisar yash-nisar force-pushed the yash-nisar:breakage-fix branch from e6b2804 to 51fb17d Jun 18, 2017
@jayvdb
Copy link
Member

jayvdb commented Jun 18, 2017

@jayvdb
Copy link
Member

jayvdb commented Jun 18, 2017

@rultor merge

@rultor
Copy link

rultor commented Jun 18, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 51fb17d into coala:master Jun 18, 2017
4 of 5 checks passed
4 of 5 checks passed
ci/dockercloud Your tests failed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/manual This commit was acknowledged.
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details
@rultor
Copy link

rultor commented Jun 18, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the yash-nisar:breakage-fix branch Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.