Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker breakage #185

Merged
merged 3 commits into from
Jun 18, 2017
Merged

Fix docker breakage #185

merged 3 commits into from
Jun 18, 2017

Conversation

yash-nisar
Copy link
Member

@yash-nisar yash-nisar commented Jun 18, 2017 •
edited by jayvdb
Loading

Closes #182 and #184

@yash-nisar
Copy link
Member Author

@jayvdb quick review ?

@gitmate-bot gitmate-bot added size/M and removed size/S labels Jun 18, 2017
@gitmate-bot gitmate-bot added size/S and removed size/M labels Jun 18, 2017
@jayvdb
Copy link
Member

jayvdb commented Jun 18, 2017

ack 79a0da1 17c883d 51fb17d

@jayvdb
Copy link
Member

jayvdb commented Jun 18, 2017

@rultor merge

@rultor
Copy link

rultor commented Jun 18, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 51fb17d into coala:master Jun 18, 2017
@rultor
Copy link

rultor commented Jun 18, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

@yash-nisar yash-nisar deleted the breakage-fix branch June 18, 2017 14:52
@jayvdb jayvdb mentioned this pull request Jun 19, 2017
Open
@jayvdb jayvdb mentioned this pull request Jun 26, 2017
Closed
@jayvdb jayvdb mentioned this pull request Jul 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
process/pending review process/pending_review size/S status/STALE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yash-nisar @jayvdb @rultor @gitmate-bot