Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing_a_great_proposol.md: update gsoc link #772

Open
wants to merge 1 commit into
base: master
from

Conversation

@Shiva-sankaran
Copy link

Shiva-sankaran commented Jan 16, 2020

Changes the old broken link with the new link
google.github.io/gsocguides/student

closes #642

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

LGTM! Nice work @Shiva-sankaran! tada

@abhishalya

EDIT: However, you might want to look at the commit. No need to use [text](link) in the commit. Also, make sure the body is less than 72 characters and the shortlog less than 50 characters.

@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Jan 16, 2020

Travis tests have failed

Hey @Shiva-sankaran,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f8e07dc0-3837-11ea-b5ea-ed59922799f5
Copy link
Member

frextrite left a comment

LGTM! Nice work @Shiva-sankaran! 🎉

@abhishalya

EDIT: However, you might want to look at the commit. No need to use [text](link) in the commit. Also, make sure the body is less than 72 characters and the shortlog less than 50 characters.

@Shiva-sankaran

This comment has been minimized.

Copy link
Author

Shiva-sankaran commented Jan 18, 2020

@frextrite @abhishalya
Even if i provide anyone of the link it exceeds the character limit. So i have removed all links from the body and changed the body correspondingly but not very informative though( if thats ok with the guidelines).

@Shiva-sankaran

This comment has been minimized.

Copy link
Author

Shiva-sankaran commented Feb 2, 2020

Hey is this PR ready to be merged or should I look into the Travis error @frextrite @abhishalya

Copy link
Member

frextrite left a comment

@Shiva-sankaran Don't forget to force-push the changes once you amend the commit ;)

For the commit body something on the lines of

Change the old broken link with the new link
google.github.io/gsocguides/student

Closes #<insert issue number>

would work!

@Shiva-sankaran

This comment has been minimized.

Copy link
Author

Shiva-sankaran commented Feb 10, 2020

@frextrite sorry about this i tried a few different commands in git in trying to force push but nothing seemed to work. The problem is i used my browser, forked repository to make this PR . now i chanced the body by again editing here in the browser. so now it seems like force push should be done in terminal and i am currecntly learning git. So the only way i found is closing this PR and starting from first again.
EDIT in my cloned copy, forked copy the link are changed

@Shiva-sankaran Shiva-sankaran force-pushed the Shiva-sankaran:Gsoc_link_fix branch from 81ca29e to 56b2985 Feb 11, 2020
@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Feb 11, 2020

Hey @Shiva-sankaran,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 459243e0-4cd5-11ea-8d64-99834d90edda
Changes the old broken link with the new link
google.github.io/gsocguides/student
closes #642
@Shiva-sankaran Shiva-sankaran force-pushed the Shiva-sankaran:Gsoc_link_fix branch from 56b2985 to fa28621 Feb 13, 2020
@TravisBuddy

This comment has been minimized.

Copy link

TravisBuddy commented Feb 13, 2020

Hey @Shiva-sankaran,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e214bd10-4e33-11ea-b00e-d175f66e4ddd
@Shiva-sankaran

This comment has been minimized.

Copy link
Author

Shiva-sankaran commented Feb 13, 2020

@frextrite so i forced pushed agian after adding the closes < issue number >. so thats it or should i make anymore changes and thanks for your patience :)

@Shiva-sankaran Shiva-sankaran requested a review from frextrite Feb 13, 2020
@@ -25,4 +25,4 @@ Please follow the **application template** in the faq. All fields are required i

For writing your proposal we recommend using [Google Docs](https://www.google.com/docs/about/) as this will be supported by the Google submission system.

If needed, you can get further information about GSoC [here](http://write.flossmanuals.net/gsocstudentguide/what-is-google-summer-of-code/).
If needed, you can get further information about GSoC [here](https://google.github.io/gsocguides/student/).

This comment has been minimized.

Copy link
@abhishalya

abhishalya Feb 16, 2020

Member

Why this link instead of the GSoC site?

This comment has been minimized.

Copy link
@Shiva-sankaran

Shiva-sankaran Feb 16, 2020

Author

Since people who are going to see this are going to be gsoc applicants so i thought this site would be better as the orginal gsoc site also has the parts for the organisation to take part in gsoc. Also in my personal experience this site is more detailed than https://summerofcode.withgoogle.com/ for newcomers that's why i have this link i thought this was also maintined by Google anyway right??
Shall i change the link then..? and I should again force push the changes right?
@abhishalya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.