-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix CLI logic and update tests #125
Conversation
Thanks for your PR! |
Can you tell me what other issues exist and maybe fix them? |
This PR looks good so far, it can be merged, right? |
Awesome!
There are currently a number of tests which have to be skipped to make the CI green :/ When you remove the I think it might be necessary to rework the setup of the argument parser a bit more and add the options to the subcommands rather than the top-level. I try have to have another look into it soon, feel free to make changes to the PR if you see a good solution before that :) |
I rebased the PR against |
Unfortunately, I can't help right now because I don't have time. It would be great if you could take care of it. |
Sure, will do :) I'll ping you once the PR is ready to be reviewed :) |
@gerdemann This PR should now be ready to be merged :) Apart from the fact that you now need to explicitly state which method you are using (e. g. |
That looks great. Thank you very much! |
@JKRhb I published a new Version 0.8.0 |
Awesome, thank you! :) |
As a follow-up to #123 this PR tries to fix the logic of the CLI and to update the test cases after the API in the light of the
commander
changes. There are currently still some issues present which is why I opened this PR as a draft for now. Feel free to already leave some review comments if you like :)Once this PR is being merged, it will fix #122.
Edit: It now also fixes #56.